Bug 1861673

Summary:	[CBT] Copy bitmaps from deleted layer (top) to the base when cold merge operation is done on a VM that contains incremental backups
Product:	[oVirt] ovirt-engine	Reporter:	Eyal Shenitzky <eshenitz>
Component:	BLL.Storage	Assignee:	Eyal Shenitzky <eshenitz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ilan Zuckerman <izuckerm>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.4.1	CC:	bugs, nsoffer, sfishbai
Target Milestone:	ovirt-4.4.3	Flags:	pm-rhel: ovirt-4.4+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-11 06:42:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1799013
Bug Blocks:

Description Eyal Shenitzky 2020-07-29 08:57:46 UTC

Description of problem:

When incremental backup introduced as a tech preview there was a known libvirt bug 1799013 for doing live/cold merge operations (using blockCommit)when the VM contains also incremental backups.

In this case, libvirt doesn't handle bitmaps used to drive the incremental backup feature during virDomainBlockCommit which leads thier curroption so a full backup needs to be taken.

Version-Release number of selected component (if applicable):
4.4.1

How reproducible:
100%

Steps to Reproduce:
1. Create a VM with disks
2. Run the VM
3. Create snapshot for the VM
3. Create an incremental backups for the VM
4. Remove the VM snapshot
7. Create another incremental backup for the VM

Actual results:
Incremental backup bitmaps got curropted and a full backup should be taken

Expected results:
Incremental backup bitmaps should be intact so a new incremental backup can be taken.

Additional info:

Comment 1 Ilan Zuckerman 2020-10-22 09:29:59 UTC

Verified on rhv-4.4.3-9

- Create a VM with disk
- Run the VM
- Take full backup of the disk
- Create snapshot with AND without memory
- Update disk property to 'incremental'
- Take incremental backup of the disk
- Remove the VM snapshot
- Take another incremental backup of the same disk, using previous 'to_checkpoint_id'

Expected:
New Incremental backup successfully completed

Actual:
New Incremental backup successfully completed

Comment 2 Sandro Bonazzola 2020-11-11 06:42:27 UTC

This bugzilla is included in oVirt 4.4.3 release, published on November 10th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.