Bug 1861673 - [CBT] Copy bitmaps from deleted layer (top) to the base when cold merge operation is done on a VM that contains incremental backups
Summary: [CBT] Copy bitmaps from deleted layer (top) to the base when cold merge opera...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.4.1
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.4.3
: ---
Assignee: Eyal Shenitzky
QA Contact: Ilan Zuckerman
URL:
Whiteboard:
Depends On: 1799013
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-07-29 08:57 UTC by Eyal Shenitzky
Modified: 2020-11-11 06:42 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-11-11 06:42:27 UTC
oVirt Team: Storage
Embargoed:
pm-rhel: ovirt-4.4+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 111179 0 master MERGED qemuimg.py: add support for 'qemu-img bitmap --merge' command 2021-01-12 08:43:15 UTC
oVirt gerrit 111180 0 master MERGED API.py: Add new merge_bitmaps flag to SDM merge() verb 2021-01-12 08:43:15 UTC
oVirt gerrit 111181 0 master MERGED sdm/api/merge.py: merge bitmaps in merge job 2021-01-12 08:43:15 UTC
oVirt gerrit 111184 0 master MERGED core: support merge bitmaps in a cold merge operation 2021-01-12 08:43:15 UTC
oVirt gerrit 111575 0 master MERGED spec: Update qemu-kvm requirement for RHEL AV 8.3 2021-01-12 08:43:15 UTC
oVirt gerrit 111652 0 master MERGED qemuimg.py: add support for enable/disable a bitmap 2021-01-12 08:43:54 UTC
oVirt gerrit 111739 0 master MERGED bitmaps.py: extract add bitmap logic to a function 2021-01-12 08:43:17 UTC

Description Eyal Shenitzky 2020-07-29 08:57:46 UTC
Description of problem:

When incremental backup introduced as a tech preview there was a known libvirt bug 1799013 for doing live/cold merge operations (using blockCommit)when the VM contains also incremental backups.

In this case, libvirt doesn't handle bitmaps used to drive the incremental backup feature during virDomainBlockCommit which leads thier curroption so a full backup needs to be taken.

Version-Release number of selected component (if applicable):
4.4.1

How reproducible:
100%

Steps to Reproduce:
1. Create a VM with disks
2. Run the VM
3. Create snapshot for the VM
3. Create an incremental backups for the VM
4. Remove the VM snapshot
7. Create another incremental backup for the VM

Actual results:
Incremental backup bitmaps got curropted and a full backup should be taken

Expected results:
Incremental backup bitmaps should be intact so a new incremental backup can be taken.

Additional info:

Comment 1 Ilan Zuckerman 2020-10-22 09:29:59 UTC
Verified on rhv-4.4.3-9

- Create a VM with disk
- Run the VM
- Take full backup of the disk
- Create snapshot with AND without memory
- Update disk property to 'incremental'
- Take incremental backup of the disk
- Remove the VM snapshot
- Take another incremental backup of the same disk, using previous 'to_checkpoint_id'

Expected:
New Incremental backup successfully completed

Actual:
New Incremental backup successfully completed

Comment 2 Sandro Bonazzola 2020-11-11 06:42:27 UTC
This bugzilla is included in oVirt 4.4.3 release, published on November 10th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.