Bug 1862719

Summary:	Remove python 2 leftovers
Product:	[oVirt] ovirt-imageio	Reporter:	Nir Soffer <nsoffer>
Component:	General	Assignee:	Vojtech Juranek <vjuranek>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Shir Fishbain <sfishbai>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	2.0.9	CC:	bugs, nsoffer, royoung, sfishbai, tnisan, vjuranek
Target Milestone:	ovirt-4.4.3
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-13 10:33:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nir Soffer 2020-08-01 19:28:37 UTC

Description of problem:

imageio source is full of useless python 2 compatibility hacks. This makes 
working with the code harder for no benefit.

No special testing is required, the standard automated tests are enough to 
check for regressions.

Example cleanups:
- Remove six usage
- Remove python3-six from spec
- Remove python3-six from docker files
- Remove python3-six from automation
- Remove tests and code to support buffer (replaced by memoryview)
- Remove skips for python 2 in tests
- Remove inheritance from object
- Remove __future__ imports
- Remove xfail_python3 and requires_python3 marks

Comment 1 Nir Soffer 2020-08-04 10:19:12 UTC

More work is needed, moving to NEW.

Comment 2 Nir Soffer 2020-08-26 11:08:15 UTC

Vojta send several patches for this, moving to him.

Comment 3 Vojtech Juranek 2020-09-14 11:42:36 UTC

> - Remove tests and code to support buffer (replaced by memoryview)

Nir, what do you mean by this? We don't use buffer() anywhere in imageio code.

Comment 4 Nir Soffer 2020-09-14 11:53:39 UTC

(In reply to Vojtech Juranek from comment #3)
> > - Remove tests and code to support buffer (replaced by memoryview)
> 
> Nir, what do you mean by this? We don't use buffer() anywhere in imageio
> code.

I think this code was already removed long time ago.

Comment 5 Vojtech Juranek 2020-09-14 12:56:17 UTC

IMHO all py2 related code was removed and can move the BZ to modified

Comment 8 Tal Nisan 2020-10-13 10:33:40 UTC

Sanity and tier tests passed, no need for verification on QE side