Bug 1862719 - Remove python 2 leftovers
Summary: Remove python 2 leftovers
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-imageio
Classification: oVirt
Component: General
Version: 2.0.9
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ovirt-4.4.3
: ---
Assignee: Vojtech Juranek
QA Contact: Shir Fishbain
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-08-01 19:28 UTC by Nir Soffer
Modified: 2020-10-13 10:33 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-13 10:33:40 UTC
oVirt Team: Storage
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 110581 0 master MERGED py3: Simplify super() calls 2020-12-21 12:33:58 UTC
oVirt gerrit 110917 0 master MERGED py3: remove six from http module 2020-12-21 12:33:58 UTC
oVirt gerrit 110918 0 master MERGED py3: remove six from uhttp module 2020-12-21 12:33:56 UTC
oVirt gerrit 110919 0 master MERGED py3: remove six from nbdutil module 2020-12-21 12:33:58 UTC
oVirt gerrit 110920 0 master MERGED py3: remove six from qemu_nbd module 2020-12-21 12:33:56 UTC
oVirt gerrit 110921 0 master MERGED py3: remove six from util module 2020-12-21 12:33:57 UTC
oVirt gerrit 110922 0 master MERGED py3: import urlparse direcly from module 2020-12-21 12:33:59 UTC
oVirt gerrit 111037 0 master MERGED py3: remove python3-six from spec file 2020-12-21 12:33:59 UTC
oVirt gerrit 111038 0 master MERGED py3: remove python3-six from automation 2020-12-21 12:34:01 UTC
oVirt gerrit 111039 0 master MERGED py3: remove python3-six from Dockerfiles 2020-12-21 12:34:00 UTC
oVirt gerrit 111040 0 master MERGED py3: remove __future__ imports 2020-12-21 12:34:00 UTC
oVirt gerrit 111042 0 master MERGED py3: remove inheritance from object 2020-12-21 12:34:00 UTC

Description Nir Soffer 2020-08-01 19:28:37 UTC 
Description of problem:

imageio source is full of useless python 2 compatibility hacks. This makes 
working with the code harder for no benefit.

No special testing is required, the standard automated tests are enough to 
check for regressions.

Example cleanups:
- Remove six usage
- Remove python3-six from spec
- Remove python3-six from docker files
- Remove python3-six from automation
- Remove tests and code to support buffer (replaced by memoryview)
- Remove skips for python 2 in tests
- Remove inheritance from object
- Remove __future__ imports
- Remove xfail_python3 and requires_python3 marks
Comment 1 Nir Soffer 2020-08-04 10:19:12 UTC 
More work is needed, moving to NEW.
Comment 2 Nir Soffer 2020-08-26 11:08:15 UTC 
Vojta send several patches for this, moving to him.
Comment 3 Vojtech Juranek 2020-09-14 11:42:36 UTC 
> - Remove tests and code to support buffer (replaced by memoryview)

Nir, what do you mean by this? We don't use buffer() anywhere in imageio code.
Comment 4 Nir Soffer 2020-09-14 11:53:39 UTC 
(In reply to Vojtech Juranek from comment #3)
> > - Remove tests and code to support buffer (replaced by memoryview)
> 
> Nir, what do you mean by this? We don't use buffer() anywhere in imageio
> code.

I think this code was already removed long time ago.
Comment 5 Vojtech Juranek 2020-09-14 12:56:17 UTC 
IMHO all py2 related code was removed and can move the BZ to modified
Comment 8 Tal Nisan 2020-10-13 10:33:40 UTC 
Sanity and tier tests passed, no need for verification on QE side
Note You need to log in before you can comment on or make changes to this bug.