Bug 1868089

Summary:	Review Request: jaxb - JAXB Reference Implementation
Product:	[Fedora] Fedora	Reporter:	Mat Booth <mat.booth>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-11 19:21:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mat Booth 2020-08-11 16:07:14 UTC

Spec URL: https://fedorapeople.org/~mbooth/reviews/jaxb.spec
SRPM URL: https://fedorapeople.org/~mbooth/reviews/jaxb-2.3.3-1.fc33.src.rpm

Description:
JAXB (JSR 222) Reference Implementation

Fedora Account System Username: mbooth

Note this is a rename-review-request renaming the package from glassfish-jaxb

Comment 1 Mat Booth 2020-08-11 16:13:59 UTC

Rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=49091730

Comment 2 Fabio Valentini 2020-08-11 16:18:48 UTC

*** Bug 1867954 has been marked as a duplicate of this bug. ***

Comment 3 Fabio Valentini 2020-08-11 16:19:37 UTC

Taking this review.

Comment 4 Fabio Valentini 2020-08-11 16:41:01 UTC

You're missing the com.sun.xml.bind:jaxb-impl alias for org.glassfish.jaxb:jaxb-runtime.
It's still mvn(depended) on by other packages (resteasy and xmlunit).

You can also just drop all the old glassfish-jaxb changelog entries, but that's not a MUST.


Other than those two points, package looks good.
I won't post the full fedora-review output, since it's boring.

Please fix the missing additional mvn_alias for com.sun.xml.bind:jaxb-impl before importing / building the package to avoid breaking resteasy and xmlunit.

Comment 5 Mat Booth 2020-08-11 16:51:27 UTC

This artifact is now supplied by a separate sub-package.

$ rpm -qp --provides jaxb-impl-2.3.3-1.fc33.noarch.rpm
jaxb-impl = 2.3.3-1.fc33
mvn(com.sun.xml.bind:jaxb-impl) = 2.3.3
mvn(com.sun.xml.bind:jaxb-impl:pom:) = 2.3.3
osgi(com.sun.xml.bind.jaxb-impl) = 2.3.3


I can drop all the changelog entries -- it's all in the git history anyway :-)

Comment 6 Fabio Valentini 2020-08-11 16:52:33 UTC

(In reply to Mat Booth from comment #5)
> This artifact is now supplied by a separate sub-package.
> 
> $ rpm -qp --provides jaxb-impl-2.3.3-1.fc33.noarch.rpm
> jaxb-impl = 2.3.3-1.fc33
> mvn(com.sun.xml.bind:jaxb-impl) = 2.3.3
> mvn(com.sun.xml.bind:jaxb-impl:pom:) = 2.3.3
> osgi(com.sun.xml.bind.jaxb-impl) = 2.3.3

I missed this. Nevermind, looks fine.

> I can drop all the changelog entries -- it's all in the git history anyway
> :-)

\o/

Comment 7 Mat Booth 2020-08-11 16:53:39 UTC

New repo request: https://pagure.io/releng/fedora-scm-requests/issue/27500

Comment 8 Gwyn Ciesla 2020-08-11 17:00:47 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/jaxb

Comment 9 Mat Booth 2020-08-11 19:21:17 UTC

Built for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=49103919