Spec URL: https://fedorapeople.org/~mbooth/reviews/jaxb.spec SRPM URL: https://fedorapeople.org/~mbooth/reviews/jaxb-2.3.3-1.fc33.src.rpm Description: JAXB (JSR 222) Reference Implementation Fedora Account System Username: mbooth Note this is a rename-review-request renaming the package from glassfish-jaxb
Rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=49091730
*** Bug 1867954 has been marked as a duplicate of this bug. ***
Taking this review.
You're missing the com.sun.xml.bind:jaxb-impl alias for org.glassfish.jaxb:jaxb-runtime. It's still mvn(depended) on by other packages (resteasy and xmlunit). You can also just drop all the old glassfish-jaxb changelog entries, but that's not a MUST. Other than those two points, package looks good. I won't post the full fedora-review output, since it's boring. Please fix the missing additional mvn_alias for com.sun.xml.bind:jaxb-impl before importing / building the package to avoid breaking resteasy and xmlunit.
This artifact is now supplied by a separate sub-package. $ rpm -qp --provides jaxb-impl-2.3.3-1.fc33.noarch.rpm jaxb-impl = 2.3.3-1.fc33 mvn(com.sun.xml.bind:jaxb-impl) = 2.3.3 mvn(com.sun.xml.bind:jaxb-impl:pom:) = 2.3.3 osgi(com.sun.xml.bind.jaxb-impl) = 2.3.3 I can drop all the changelog entries -- it's all in the git history anyway :-)
(In reply to Mat Booth from comment #5) > This artifact is now supplied by a separate sub-package. > > $ rpm -qp --provides jaxb-impl-2.3.3-1.fc33.noarch.rpm > jaxb-impl = 2.3.3-1.fc33 > mvn(com.sun.xml.bind:jaxb-impl) = 2.3.3 > mvn(com.sun.xml.bind:jaxb-impl:pom:) = 2.3.3 > osgi(com.sun.xml.bind.jaxb-impl) = 2.3.3 I missed this. Nevermind, looks fine. > I can drop all the changelog entries -- it's all in the git history anyway > :-) \o/
New repo request: https://pagure.io/releng/fedora-scm-requests/issue/27500
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/jaxb
Built for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=49103919