Bug 1871178

Summary: Make "Enable operator recommended cluster monitoring on this namespace" option enabled by default
Product: [Red Hat Storage] Red Hat OpenShift Container Storage Reporter: Martin Bukatovic <mbukatov>
Component: management-consoleAssignee: Nishanth Thomas <nthomas>
Status: CLOSED WONTFIX QA Contact: Elad <ebenahar>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.5CC: jefbrown, madam, ocs-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1871771 (view as bug list) Environment:
Last Closed: 2020-09-14 11:41:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1871771    
Attachments:
Description Flags
screenshot of "Install Operator" wizard of OCS 4.5 operator none

Description Martin Bukatovic 2020-08-21 13:58:22 UTC
Created attachment 1712178 [details]
screenshot of "Install Operator" wizard of OCS 4.5 operator

Description of problem
======================

When OpenShift Container Storage operator is installed, the installation wizard
provides operator recommended values for namespace of the operator.

It's recommendation about monitoring configuration for the namespace is a bit
confusing, because:

- it tells the user that recommended configuration of the monitoring is enabled
- but the default value of the monitoring option is disabled
- it warns the user about implications of using monitoring with non Red Hat
  (3rd party) operators, even though OCS is a Red Hat product

Version-Release number of selected component
============================================

OCP 4.5.0-0.ci-2020-08-19-184304
OCS 4.5.0-526.ci

How reproducible
================

1/1

Steps to Reproduce
==================

1. Find "Openshift Container Storage" (aka OCS) operator in Operator hub of OCP
   cluster (using at least the version listed above)
2. Click on "Install" button of the operator to reach "Install Operator" page
3. See the default options in the installation wizard

Actual results
==============

The "Install Operator" page of OCS operator provides these defaults:

- "openshift-storage" namespace is preselected (as operator recommended option)
- option "Enable operator recommended cluster monitoring on this namespace"
  is disabled by default
- warning about namespace monitoring on 3rd party (non Red Hat) operators is
  shown

See attached screenshot.

This is little confusing, because:

- operator recommendation about name of the namespace is preselected, but it's
  recomentation for monitoring on the namespace is not
- warning about non Red Hat operator is shown in Red Hat operator

Expected results
================

The "Install Operator" page of OCS operator provides these defaults:

- "openshift-storage" namespace is preselected (as operator recommended option)
- option "Enable operator recommended cluster monitoring on this namespace"
  is enabled by default
- there is no warning about namespace monitoring on 3rd party (non Red Hat)
  operators is shown

Note about the fact that namespace monitoring is expected to be enabled could
be shown. But one should still be able to disable it though.

Comment 2 Martin Bukatovic 2020-08-21 14:00:24 UTC
Please evaluate whether changes in OCP Console are necessary for this to be fixed.

Comment 3 Sébastien Han 2020-08-24 08:45:32 UTC
Moving to UI.

Comment 4 Michael Adam 2020-08-27 14:37:28 UTC
can't fix for 4.5.0
moving to 4.6
we can possible talk about a 4.5.z backport

Comment 5 Nishanth Thomas 2020-08-27 19:10:28 UTC
@Martin, Based on https://bugzilla.redhat.com/show_bug.cgi?id=1871771#c1, we have to close this Bz as well.
Let me know if you have any concerns.

Comment 6 Martin Bukatovic 2020-09-03 07:37:11 UTC
(In reply to Nishanth Thomas from comment #5)
> @Martin, Based on https://bugzilla.redhat.com/show_bug.cgi?id=1871771#c1, we
> have to close this Bz as well.
> Let me know if you have any concerns.

The bug deals with 2 related concerns (which both myself and Jakub from
OCP team considered closely related at first):

- Console warns the user about implications of using monitoring with non Red Hat
  (3rd party) operators, even though OCS is a Red Hat product
- the default value of the monitoring option is disabled

As you are correctly pointing out, Jakub noted that 1st concern is caused
by "opsrc-provider=redhat" label.

But the 2nd part: the default value of the monitoring option is disabled,
could still be a problem, as explained here:

https://bugzilla.redhat.com/show_bug.cgi?id=1871771#c4

Since then, OCP team moved BZ 1871771 to assigned, so I suggest to keep this
open as well, for tracking purposes. At this point, it's not clear if OCP or
OCS code change (or both) will be necessary.

Comment 7 Nishanth Thomas 2020-09-14 11:41:50 UTC
Per https://bugzilla.redhat.com/show_bug.cgi?id=1871771#c6, closing this Bz as well

Comment 8 Martin Bukatovic 2020-12-10 11:13:06 UTC
This is a duplicate of BZ 1871178, which is blocked by BZ 1871771. The bug is pending PM intervention.

Comment 9 Martin Bukatovic 2020-12-10 11:15:31 UTC
(In reply to Martin Bukatovic from comment #8)
> This is a duplicate of BZ 1871178, which is blocked by BZ 1871771. The bug
> is pending PM intervention.

Please ignore the above.