+++ This bug was initially created as a clone of Bug #1871178 +++ This bug is cloned to OCP Console component to make sure it's visible and processed by both OCP and OCS teams as expected. Description of problem ====================== When OpenShift Container Storage operator is installed, the installation wizard provides operator recommended values for namespace of the operator. It's recommendation about monitoring configuration for the namespace is a bit confusing, because: - it tells the user that recommended configuration of the monitoring is enabled - but the default value of the monitoring option is disabled - it warns the user about implications of using monitoring with non Red Hat (3rd party) operators, even though OCS is a Red Hat product Version-Release number of selected component ============================================ OCP 4.5.0-0.ci-2020-08-19-184304 OCS 4.5.0-526.ci How reproducible ================ 1/1 Steps to Reproduce ================== 1. Find "Openshift Container Storage" (aka OCS) operator in Operator hub of OCP cluster (using at least the version listed above) 2. Click on "Install" button of the operator to reach "Install Operator" page 3. See the default options in the installation wizard Actual results ============== The "Install Operator" page of OCS operator provides these defaults: - "openshift-storage" namespace is preselected (as operator recommended option) - option "Enable operator recommended cluster monitoring on this namespace" is disabled by default - warning about namespace monitoring on 3rd party (non Red Hat) operators is shown See attached screenshot. This is little confusing, because: - operator recommendation about name of the namespace is preselected, but it's recomentation for monitoring on the namespace is not - warning about non Red Hat operator is shown in Red Hat operator Expected results ================ The "Install Operator" page of OCS operator provides these defaults: - "openshift-storage" namespace is preselected (as operator recommended option) - option "Enable operator recommended cluster monitoring on this namespace" is enabled by default - there is no warning about namespace monitoring on 3rd party (non Red Hat) operators is shown Note about the fact that namespace monitoring is expected to be enabled could be shown. But one should still be able to disable it though. --- Additional comment from RHEL Program Management on 2020-08-21 15:58:30 CEST --- This bug having no release flag set previously, is now set with release flag 'ocs‑4.5.0' to '?', and so is being proposed to be fixed at the OCS 4.5.0 release. If this bug should be proposed for a different release, please manually change the proposed release flag. Note that the 3 Acks (pm_ack, devel_ack, qa_ack), if any previously set while release flag was missing, have now been reset since the Acks are to be set against a release flag --- Additional comment from Martin Bukatovic on 2020-08-21 16:00:24 CEST --- Please evaluate whether changes in OCP Console are necessary for this to be fixed. --- Additional comment from leseb on 2020-08-24 10:45:32 CEST --- Moving to UI.
The warning about namespace monitoring on 3rd party is bacause the 'OpenShift Container Storage' operator's PackageManifest is missing "opsrc-provider=redhat" label. We use this label to distinguish between RH and 3rd party operators. Regarding the unchecked checkbox, thats by design - https://github.com/openshift/openshift-origin-design/pull/307#discussion_r363273005 Don't think this is a bug so closing this one. Feel free to reopen in case you feel different.
Thanks for the references, this is really helpful. Even with our CI build we usually see `opsrc-provider=redhat` label to be present, eg.: ``` $ oc get PackageManifest/ocs-operator -o yaml | grep opsrc- opsrc-datastore: "true" opsrc-owner-name: redhat-operators opsrc-owner-namespace: openshift-marketplace opsrc-provider: redhat $ oc get csv -n openshift-storage NAME DISPLAY VERSION REPLACES PHASE ocs-operator.v4.5.0-526.ci OpenShift Container Storage 4.5.0-526.ci Succeeded ``` I will recheck this and reopen the BZ with more details, if necessary.
> Regarding the unchecked checkbox, thats by design - https://github.com/openshift/openshift-origin-design/pull/307#discussion_r363273005 I see that the comment you referenced notes: > we want to write that this voids support, at least from monitoring side, if the user enables > monitoring in a openshift-* namespace and then installs other non red hat operators in that > namespace. Do I read this right that with properly labeled OCS operator, installation into suggested openshift-storage namespace should not present enable monitoring checkbox disabled by default, when the operator is suggesting otherwise? I'm asking because with stable and released OCS 4.4.2 which has the labels configured right, I still see the monitoring checkbox unchecked by default. I can't check how it works with OCS 4.5 because of 1872335 though. The point here is that OCS requires the monitoring to be enabled to be supported. We also don't test OCS without monitoring.
Reopening to raise attention to the question from comment #4.
Yes, this is by design. We do not check the checkbox by default. Allowing an operator to contribute metrics to the cluster prometheus instance is high risk. The admin must explicitly check the box to enable it, no matter what the operator requests. I understand OCS requires it, but the default applies to all operators.
I see that in comment 6 we acknowledged the problem exists, and also noted that it won't be fixed. Fixing the bug status to align with this as WONTFIX.
Yes, Eran, that's the solution we will be following.