Bug 1871771
| Summary: | Make "Enable operator recommended cluster monitoring on this namespace" option enabled by default | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Martin Bukatovic <mbukatov> |
| Component: | Management Console | Assignee: | Jakub Hadvig <jhadvig> |
| Status: | CLOSED WONTFIX | QA Contact: | Yadan Pei <yapei> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 4.5 | CC: | aos-bugs, asachan, badhikar, ebenahar, etamir, jefbrown, jhadvig, jokerman, madam, nthomas, ocs-bugs, spadgett |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | 4.7.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1871178 | Environment: | |
| Last Closed: | 2020-09-11 17:48:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1871178 | ||
| Bug Blocks: | |||
|
Description
Martin Bukatovic
2020-08-24 08:59:45 UTC
The warning about namespace monitoring on 3rd party is bacause the 'OpenShift Container Storage' operator's PackageManifest is missing "opsrc-provider=redhat" label. We use this label to distinguish between RH and 3rd party operators. Regarding the unchecked checkbox, thats by design - https://github.com/openshift/openshift-origin-design/pull/307#discussion_r363273005 Don't think this is a bug so closing this one. Feel free to reopen in case you feel different. Thanks for the references, this is really helpful.
Even with our CI build we usually see `opsrc-provider=redhat` label to be present, eg.:
```
$ oc get PackageManifest/ocs-operator -o yaml | grep opsrc-
opsrc-datastore: "true"
opsrc-owner-name: redhat-operators
opsrc-owner-namespace: openshift-marketplace
opsrc-provider: redhat
$ oc get csv -n openshift-storage
NAME DISPLAY VERSION REPLACES PHASE
ocs-operator.v4.5.0-526.ci OpenShift Container Storage 4.5.0-526.ci Succeeded
```
I will recheck this and reopen the BZ with more details, if necessary.
> Regarding the unchecked checkbox, thats by design - https://github.com/openshift/openshift-origin-design/pull/307#discussion_r363273005 I see that the comment you referenced notes: > we want to write that this voids support, at least from monitoring side, if the user enables > monitoring in a openshift-* namespace and then installs other non red hat operators in that > namespace. Do I read this right that with properly labeled OCS operator, installation into suggested openshift-storage namespace should not present enable monitoring checkbox disabled by default, when the operator is suggesting otherwise? I'm asking because with stable and released OCS 4.4.2 which has the labels configured right, I still see the monitoring checkbox unchecked by default. I can't check how it works with OCS 4.5 because of 1872335 though. The point here is that OCS requires the monitoring to be enabled to be supported. We also don't test OCS without monitoring. Reopening to raise attention to the question from comment #4. Yes, this is by design. We do not check the checkbox by default. Allowing an operator to contribute metrics to the cluster prometheus instance is high risk. The admin must explicitly check the box to enable it, no matter what the operator requests. I understand OCS requires it, but the default applies to all operators. I see that in comment 6 we acknowledged the problem exists, and also noted that it won't be fixed. Fixing the bug status to align with this as WONTFIX. Yes, Eran, that's the solution we will be following. |