Bug 1871890

Summary:	add current profile annotations to CVO manifests
Product:	OpenShift Container Platform	Reporter:	Sam Batschelet <sbatsche>
Component:	Etcd	Assignee:	Suresh Kolichala <skolicha>
Status:	CLOSED ERRATA	QA Contact:	ge liu <geliu>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.6	CC:	deads, gurose, rkukura, skolicha, wking
Target Milestone:	---
Target Release:	4.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-27 16:31:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sam Batschelet 2020-08-24 14:37:46 UTC

Description of problem: currently CVO managed resources do not contain current profile annotations as per enhancements[1]

```
include.release.openshift.io/self-managed-high-availability: "true"
```

[1] https://github.com/openshift/enhancements/pull/414


Version-Release number of selected component (if applicable):


How reproducible: 100%


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results: proper annotations exist.


Additional info:

Comment 1 David Eads 2020-08-24 14:53:45 UTC

*** Bug 1871898 has been marked as a duplicate of this bug. ***

Comment 3 W. Trevor King 2020-09-18 20:21:16 UTC

Still a bunch of open PRs.  Moving back to POST.

Comment 6 W. Trevor King 2020-09-29 22:37:33 UTC

Do we consider this done?  There are a lot of manifests that will be excluded if we start requiring this annotation with the current manifest state:

$ curl -s https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp-dev-preview/4.6.0-0.nightly-2020-09-29-170625/release.txt | sed -n 's/Pull From: //p'
quay.io/openshift-release-dev/ocp-release-nightly@sha256:0a34786b184297b641ca33d85ba80da0d52a0f6e7a72077c68a33a9ad36f4f35
$ oc adm release extract --to manifests quay.io/openshift-release-dev/ocp-release-nightly@sha256:0a34786b184297b641ca33d85ba80da0d52a0f6e7a72077c68a33a9ad36f4f35
$ grep -rc 'include.release.openshift.io/self-managed-high-availability' manifests | grep '\.yaml:0$' | sort | head
manifests/0000_05_config-operator_02_apiserver.cr.yaml:0
manifests/0000_05_config-operator_02_authentication.cr.yaml:0
manifests/0000_05_config-operator_02_build.cr.yaml:0
...

I would have expected the config operator, machine-API operator, etc. to remain part of the self-managed-high-availability profile.  Just counting by filename:

$ grep -rc 'include.release.openshift.io/self-managed-high-availability' manifests | grep '\.yaml:0$' | wc -l
293
$ grep -rc 'include.release.openshift.io/self-managed-high-availability' manifests | grep '\.yaml:[^0]$' | wc -l
150

so we are ~1/3 of the way there, assuming only a very few or zero manifests should be excluded from the self-managed-high-availability profile.

Comment 9 errata-xmlrpc 2020-10-27 16:31:27 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196

Comment 10 Guillaume Rose 2020-12-14 09:04:34 UTC

2 components are still missing some annotations: OLM and cluster storage.

https://github.com/openshift/cluster-storage-operator/pull/117
https://github.com/operator-framework/operator-lifecycle-manager/pull/1887