Bug 1871890 - add current profile annotations to CVO manifests
Summary: add current profile annotations to CVO manifests
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Etcd
Version: 4.6
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.6.0
Assignee: Suresh Kolichala
QA Contact: ge liu
URL:
Whiteboard:
: 1871898 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-08-24 14:37 UTC by Sam Batschelet
Modified: 2020-12-14 09:04 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-27 16:31:27 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift api pull 722 0 None closed bug 1871890: add current profile annotations to CVO manifests 2021-02-16 06:01:57 UTC
Github openshift api pull 723 0 None closed bug 1871890: add current profile annotations to CVO manifests 2021-02-16 06:01:57 UTC
Github openshift api pull 724 0 None closed bug 1871890: add current profile annotations to CVO manifests 2021-02-16 06:01:57 UTC
Github openshift cluster-authentication-operator pull 352 0 None closed bug 1871890: add current profile annotations to CVO manifests 2021-02-16 06:01:58 UTC
Github openshift cluster-config-operator pull 156 0 None closed bug 1871890: add current profile annotations to CVO manifests 2021-02-16 06:01:57 UTC
Github openshift cluster-etcd-operator pull 427 0 None closed Bug 1871890: add current profile annotations to CVO manifests 2021-02-16 06:01:57 UTC
Github openshift cluster-kube-apiserver-operator pull 957 0 None closed bug 1871890: add current profile annotations to CVO manifests 2021-02-16 06:01:58 UTC
Github openshift cluster-kube-controller-manager-operator pull 456 0 None closed bug 1871890: add current profile annotations to CVO manifests 2021-02-16 06:01:58 UTC
Github openshift cluster-kube-scheduler-operator pull 273 0 None closed bug 1871890: add current profile annotations to CVO manifests 2021-02-16 06:01:59 UTC
Github openshift cluster-openshift-apiserver-operator pull 381 0 None closed bug 1871890: add current profile annotations to CVO manifests 2021-02-16 06:01:58 UTC
Github openshift cluster-openshift-apiserver-operator pull 383 0 None closed Bug 1871890: Bump coao to golang 1.14 to match kube 2021-02-16 06:01:58 UTC
Github openshift cluster-openshift-controller-manager-operator pull 178 0 None closed bug 1871890: add current profile annotations to CVO manifests 2021-02-16 06:01:59 UTC
Red Hat Product Errata RHBA-2020:4196 0 None None None 2020-10-27 16:31:41 UTC

Description Sam Batschelet 2020-08-24 14:37:46 UTC
Description of problem: currently CVO managed resources do not contain current profile annotations as per enhancements[1]

```
include.release.openshift.io/self-managed-high-availability: "true"
```

[1] https://github.com/openshift/enhancements/pull/414


Version-Release number of selected component (if applicable):


How reproducible: 100%


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results: proper annotations exist.


Additional info:

Comment 1 David Eads 2020-08-24 14:53:45 UTC
*** Bug 1871898 has been marked as a duplicate of this bug. ***

Comment 3 W. Trevor King 2020-09-18 20:21:16 UTC
Still a bunch of open PRs.  Moving back to POST.

Comment 6 W. Trevor King 2020-09-29 22:37:33 UTC
Do we consider this done?  There are a lot of manifests that will be excluded if we start requiring this annotation with the current manifest state:

$ curl -s https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp-dev-preview/4.6.0-0.nightly-2020-09-29-170625/release.txt | sed -n 's/Pull From: //p'
quay.io/openshift-release-dev/ocp-release-nightly@sha256:0a34786b184297b641ca33d85ba80da0d52a0f6e7a72077c68a33a9ad36f4f35
$ oc adm release extract --to manifests quay.io/openshift-release-dev/ocp-release-nightly@sha256:0a34786b184297b641ca33d85ba80da0d52a0f6e7a72077c68a33a9ad36f4f35
$ grep -rc 'include.release.openshift.io/self-managed-high-availability' manifests | grep '\.yaml:0$' | sort | head
manifests/0000_05_config-operator_02_apiserver.cr.yaml:0
manifests/0000_05_config-operator_02_authentication.cr.yaml:0
manifests/0000_05_config-operator_02_build.cr.yaml:0
...

I would have expected the config operator, machine-API operator, etc. to remain part of the self-managed-high-availability profile.  Just counting by filename:

$ grep -rc 'include.release.openshift.io/self-managed-high-availability' manifests | grep '\.yaml:0$' | wc -l
293
$ grep -rc 'include.release.openshift.io/self-managed-high-availability' manifests | grep '\.yaml:[^0]$' | wc -l
150

so we are ~1/3 of the way there, assuming only a very few or zero manifests should be excluded from the self-managed-high-availability profile.

Comment 9 errata-xmlrpc 2020-10-27 16:31:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196

Comment 10 Guillaume Rose 2020-12-14 09:04:34 UTC
2 components are still missing some annotations: OLM and cluster storage.

https://github.com/openshift/cluster-storage-operator/pull/117
https://github.com/operator-framework/operator-lifecycle-manager/pull/1887


Note You need to log in before you can comment on or make changes to this bug.