Bug 1872733

Summary:	Review Request: golang-github-golangci-lint-1 - Fork of the official Go linter with API enhancements
Product:	[Fedora] Fedora	Reporter:	Ondřej Budai <obudai>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-28 08:40:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1873339

Description Ondřej Budai 2020-08-26 14:04:24 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/obudai/oapi-codegen/fedora-rawhide-x86_64/01635435-golang-github-golangci-lint-1/golang-github-golangci-lint-1.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/obudai/oapi-codegen/fedora-rawhide-x86_64/01635435-golang-github-golangci-lint-1/golang-github-golangci-lint-1-0-0.1.20200826gitd2cdd8c.fc34.src.rpm
Description: Fork of the official Go linter with API enhancements
Fedora Account System Username: obudai

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=50187311

Comment 1 Robert-André Mauchin 🐧 2020-08-27 20:21:46 UTC

 - /usr/bin/golint conflict with golang-x-lint. Add a Conflicts or remove the binary if it is not essential, only keeping the library.

 - What is the reason for packaging this fork? Doesn't the original suit your needs?

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Comment 2 Robert-André Mauchin 🐧 2020-08-27 20:25:44 UTC

AH this package is on my TODO list too:

golang-github-labstack-gommon N
  golang-github-denverdino-aliyungo
  golang-github-labstack-echo-4 N
    golang-github-golangci-lint-1 N
      golang-github-deepmap-oapi-codegen N
        golang-github-exoscale-egoscale

Package is approved but remove the binary, it's not needed in this chain of dependencies.

Comment 3 Gwyn Ciesla 2020-08-27 20:45:44 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-golangci-lint

Comment 4 Igor Raits 2020-08-28 08:23:23 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-golangci-lint-1

Comment 5 Ondřej Budai 2020-08-28 08:40:24 UTC

I made a mistake with the package name, the package should be called golang-github-golangci-lint-1, not golang-github-golangci-lint. The repository with the bad name was retired and the right one will be used to do the builds. Sorry!