Bug 1872733 - Review Request: golang-github-golangci-lint-1 - Fork of the official Go linter with API enhancements
Summary: Review Request: golang-github-golangci-lint-1 - Fork of the official Go linte...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1873339
TreeView+ depends on / blocked
 
Reported: 2020-08-26 14:04 UTC by Ondřej Budai
Modified: 2020-08-28 08:40 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-08-28 08:40:24 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Comment 1 Robert-André Mauchin 🐧 2020-08-27 20:21:46 UTC
 - /usr/bin/golint conflict with golang-x-lint. Add a Conflicts or remove the binary if it is not essential, only keeping the library.

 - What is the reason for packaging this fork? Doesn't the original suit your needs?

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Comment 2 Robert-André Mauchin 🐧 2020-08-27 20:25:44 UTC
AH this package is on my TODO list too:

golang-github-labstack-gommon N
  golang-github-denverdino-aliyungo
  golang-github-labstack-echo-4 N
    golang-github-golangci-lint-1 N
      golang-github-deepmap-oapi-codegen N
        golang-github-exoscale-egoscale

Package is approved but remove the binary, it's not needed in this chain of dependencies.

Comment 3 Gwyn Ciesla 2020-08-27 20:45:44 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-golangci-lint

Comment 4 Igor Raits 2020-08-28 08:23:23 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-golangci-lint-1

Comment 5 Ondřej Budai 2020-08-28 08:40:24 UTC
I made a mistake with the package name, the package should be called golang-github-golangci-lint-1, not golang-github-golangci-lint. The repository with the bad name was retired and the right one will be used to do the builds. Sorry!


Note You need to log in before you can comment on or make changes to this bug.