Bug 187314

Summary:	Review Request: perl-Data-HexDump
Product:	[Fedora] Fedora	Reporter:	Andreas Thienemann <andreas>
Component:	Package Review	Assignee:	Paul Howarth <paul>
Status:	CLOSED ERRATA	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-03-30 15:24:00 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 187313

Description Andreas Thienemann 2006-03-29 22:26:27 UTC

Spec Name or Url: http://home.bawue.net/~ixs/perl-Data-HexDump/perl-Data-HexDump.spec
SRPM Name or Url: http://home.bawue.net/~ixs/perl-Data-HexDump/perl-Data-HexDump-0.02-1.src.rpm
Description:
Dump in hexadecimal the content of a scalar. The result is returned in a
string. Each line of the result consists of the offset in the source in the
leftmost column of each line, followed by one or more columns of data from
the source in hexadecimal. The rightmost column of each line shows the
printable characters (all others are shown as single dots).

Comment 1 Paul Howarth 2006-03-30 11:40:45 UTC

Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec file written in English and is legible
- sources match upstream
- package builds OK on FC5 (i386) and in mock for rawhide (i386)
- BR's OK
- no locales, libraries, subpackages, or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions problems
- no completely duplicate files
- %clean section present and correct
- code, not context
- no large docs
- docs don't affect runtime
- no desktop file needed
- hexdump.pl appears to function correctly
- no scriptlets

Needswork:

- macro usage inconsistent:
  use $RPM_BUILD_ROOT or %{buildroot} but not both in the same spec

Suggestions:

- It is not necessary to generate and ship the COPYING and Artistic license
  texts; inclusion of license texts is only mandatory when upstream provide
  them.

- Inclusion of hexdump as %doc is redundant since it's basically the same thing
  as %{_bindir}/hexdump.pl

Comment 2 Andreas Thienemann 2006-03-30 12:32:57 UTC

(In reply to comment #1)

> - macro usage inconsistent:
>   use $RPM_BUILD_ROOT or %{buildroot} but not both in the same spec
fixed
 
> - It is not necessary to generate and ship the COPYING and Artistic license
>   texts; inclusion of license texts is only mandatory when upstream provide
>   them.
removed
 
> - Inclusion of hexdump as %doc is redundant since it's basically the same thing
>   as %{_bindir}/hexdump.pl
removed



Spec Name or Url:
http://home.bawue.net/~ixs/perl-Data-HexDump/perl-Data-HexDump.spec
SRPM Name or Url:
http://home.bawue.net/~ixs/perl-Data-HexDump/perl-Data-HexDump-0.02-2.src.rpm

Comment 3 Paul Howarth 2006-03-30 12:37:02 UTC

perl-Data-HexDump-0.02-2 Approved.

Comment 4 Andreas Thienemann 2006-03-30 15:24:00 UTC

Thx for the review. Package is in cvs.

Comment 5 Fedora Update System 2017-07-27 08:15:35 UTC

perl-Authen-Radius-0.26-4.el7 perl-Data-HexDump-0.02-26.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-d0f7e44663

Comment 6 Fedora Update System 2017-08-10 23:53:59 UTC

perl-Authen-Radius-0.26-4.el7, perl-Data-HexDump-0.02-26.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.