Red Hat Bugzilla – Bug 187314
Review Request: perl-Data-HexDump
Last modified: 2007-11-30 17:11:28 EST
Spec Name or Url: http://home.bawue.net/~ixs/perl-Data-HexDump/perl-Data-HexDump.spec SRPM Name or Url: http://home.bawue.net/~ixs/perl-Data-HexDump/perl-Data-HexDump-0.02-1.src.rpm Description: Dump in hexadecimal the content of a scalar. The result is returned in a string. Each line of the result consists of the offset in the source in the leftmost column of each line, followed by one or more columns of data from the source in hexadecimal. The rightmost column of each line shows the printable characters (all others are shown as single dots).
Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec - spec file written in English and is legible - sources match upstream - package builds OK on FC5 (i386) and in mock for rawhide (i386) - BR's OK - no locales, libraries, subpackages, or pkgconfigs to worry about - not relocatable - no directory ownership or permissions problems - no completely duplicate files - %clean section present and correct - code, not context - no large docs - docs don't affect runtime - no desktop file needed - hexdump.pl appears to function correctly - no scriptlets Needswork: - macro usage inconsistent: use $RPM_BUILD_ROOT or %{buildroot} but not both in the same spec Suggestions: - It is not necessary to generate and ship the COPYING and Artistic license texts; inclusion of license texts is only mandatory when upstream provide them. - Inclusion of hexdump as %doc is redundant since it's basically the same thing as %{_bindir}/hexdump.pl
(In reply to comment #1) > - macro usage inconsistent: > use $RPM_BUILD_ROOT or %{buildroot} but not both in the same spec fixed > - It is not necessary to generate and ship the COPYING and Artistic license > texts; inclusion of license texts is only mandatory when upstream provide > them. removed > - Inclusion of hexdump as %doc is redundant since it's basically the same thing > as %{_bindir}/hexdump.pl removed Spec Name or Url: http://home.bawue.net/~ixs/perl-Data-HexDump/perl-Data-HexDump.spec SRPM Name or Url: http://home.bawue.net/~ixs/perl-Data-HexDump/perl-Data-HexDump-0.02-2.src.rpm
perl-Data-HexDump-0.02-2 Approved.
Thx for the review. Package is in cvs.