Bug 1875179

Summary: crio configuration changes unexpectedly when ctrcfg is applied
Product: OpenShift Container Platform Reporter: Peter Hunt <pehunt>
Component: NodeAssignee: Peter Hunt <pehunt>
Status: CLOSED ERRATA QA Contact: Sunil Choudhary <schoudha>
Severity: low Docs Contact:
Priority: low    
Version: 4.6CC: aos-bugs, jokerman
Target Milestone: ---   
Target Release: 4.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1875180 (view as bug list) Environment:
Last Closed: 2020-10-27 16:37:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1875180    

Description Peter Hunt 2020-09-02 23:55:56 UTC
Description of problem:
when a ctrcfg is applied, the resulting configuration has unintended changes. The most notable is the value of `default_env` becomes empty. The others (all containers/storage parameters) can be empty, because of the way crio mixes crio.conf and storage.conf. However, the default_env being empty can cause regressions in nss db.

Version-Release number of selected component (if applicable):
4.4 and 4.3

How reproducible:


Steps to Reproduce:
1. run `crio config` on a node
2. apply any ctrcfg
3. run `crio config` on a node, and observe the difference

Actual results:
the field
```
    default_env = [
        "NSS_SDB_USE_CACHE=no",
    ]
```
is now
```
    default_env = [
    ]
```
Expected results:
default_env should not have been emptied

Additional info:

Comment 1 Peter Hunt 2020-09-02 23:57:15 UTC
This comes from the vendored version of cri-o becoming out of sync with the version of cri-o in openshift. When we make a change in the configuration values, we need to update the vendor.

From my testing, this is no longer the case in 4.6, as it has a vendored version of cri-o that contains default_env

Comment 6 errata-xmlrpc 2020-10-27 16:37:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196