Bug 1876913

Summary:	Git clone with proxy fails after RHEL8 migration
Product:	OpenShift Container Platform	Reporter:	Adam Kaplan <adam.kaplan>
Component:	Build	Assignee:	Adam Kaplan <adam.kaplan>
Status:	CLOSED ERRATA	QA Contact:	wewang <wewang>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	4.6	CC:	aos-bugs, wzheng
Target Milestone:	---
Target Release:	4.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-27 16:38:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Adam Kaplan 2020-09-08 13:51:37 UTC

Description of problem:

Git clones fail if the git client is configured with *_PROXY environment variables and attempts to clone a repository in the NO_PROXY domain list.


Version-Release number of selected component (if applicable): 4.6.0


How reproducible: Always


Steps to Reproduce:
1. Configure a build to clone from github.com via a proxy in it's git source, with NO_PROXY set to include github.com
2. Run the build.

Actual results:

Build fails cloning source


Expected results:

Build is able to clone source


Additional info:

Related RHEL git bug: https://bugzilla.redhat.com/show_bug.cgi?id=1875639

Comment 1 Adam Kaplan 2020-09-08 13:52:18 UTC

Targeting 4.6 - considering this a release blocker.

Comment 5 wewang 2020-09-10 13:37:02 UTC

Since it's urgent bug, forgot to verify it in daytime, Now verify it in version:
version:
4.6.0-0.nightly-2020-09-09-173545

Steps:
using the file: https://raw.githubusercontent.com/adambkaplan/origin/master/test/extended/testdata/builds/test-build-proxy.yaml to test manually
[wewang@wangwen ~]$ oc get builds
NAME                            TYPE     FROM          STATUS                        STARTED              DURATION
sample-build-1                  Source   Git           Failed (GenericBuildFailed)   3 minutes ago        17s
sample-s2i-build-noproxy-1      Source   Git@57073c0   Complete                      2 minutes ago        16s
sample-s2i-build-noproxy-2      Source   Git@57073c0   Complete                      2 minutes ago        10s
sample-docker-build-noproxy-1   Docker   Git@57073c0   Complete                      About a minute ago   47s

sample-build-1 build failed, sample-s2i-build-noproxy-1  and sample-docker-build-noproxy-1 build complete are expected result.

Comment 7 errata-xmlrpc 2020-10-27 16:38:34 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196