Description of problem:
Git clones fail if the git client is configured with *_PROXY environment variables and attempts to clone a repository in the NO_PROXY domain list.
Version-Release number of selected component (if applicable): 4.6.0
How reproducible: Always
Steps to Reproduce:
1. Configure a build to clone from github.com via a proxy in it's git source, with NO_PROXY set to include github.com
2. Run the build.
Build fails cloning source
Build is able to clone source
Related RHEL git bug: https://bugzilla.redhat.com/show_bug.cgi?id=1875639
Targeting 4.6 - considering this a release blocker.
Since it's urgent bug, forgot to verify it in daytime, Now verify it in version:
using the file: https://raw.githubusercontent.com/adambkaplan/origin/master/test/extended/testdata/builds/test-build-proxy.yaml to test manually
[wewang@wangwen ~]$ oc get builds
NAME TYPE FROM STATUS STARTED DURATION
sample-build-1 Source Git Failed (GenericBuildFailed) 3 minutes ago 17s
sample-s2i-build-noproxy-1 Source Git@57073c0 Complete 2 minutes ago 16s
sample-s2i-build-noproxy-2 Source Git@57073c0 Complete 2 minutes ago 10s
sample-docker-build-noproxy-1 Docker Git@57073c0 Complete About a minute ago 47s
sample-build-1 build failed, sample-s2i-build-noproxy-1 and sample-docker-build-noproxy-1 build complete are expected result.