Bug 1878260

Summary: Review Request: rust-picky - Portable X.509, Jose and PKI implementation
Product: [Fedora] Fedora Reporter: Peter Robinson <pbrobinson>
Component: Package ReviewAssignee: Cole Robinson <crobinso>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: crobinso, marcandre.lureau, package-review
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: rust-picky (view as bug list) Environment:
Last Closed: 2025-02-09 16:52:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2329181, 2343680    

Description Peter Robinson 2020-09-11 17:38:45 UTC
SPEC: https://pbrobinson.fedorapeople.org/rust-picky.spec
SRPM: https://pbrobinson.fedorapeople.org/rust-picky-5.1.1-1.fc32.src.rpm

Description:
Portable X.509, Jose and PKI implementation

FAS: pbrobinson

Comment 1 Peter Robinson 2020-09-14 17:52:25 UTC
While parsec had a dep on this is doesn't actually use it.

Comment 2 Marc-Andre Lureau 2025-01-14 07:07:29 UTC
reopening for sspi packaging

Comment 3 Marc-Andre Lureau 2025-01-14 07:09:13 UTC
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-picky/rust-picky.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/fedora-rawhide-x86_64/08318474-rust-picky/rust-picky-7.0.0~rc.11-1.fc42.src.rpm
Description: Portable X.509, PKI, JOSE and HTTP signature implementation.
Fedora Account System Username: elmarco

Comment 4 Cole Robinson 2025-01-30 15:39:32 UTC
I'll take this. Content is basically straight `rust2rpm picky.0-rc.11` so nothing controversial.
Looks like -rc.12 was released in the meantime though.
Can you resubmit with that version, and using rust2rpm v27, and I'll finish review

Comment 5 Cole Robinson 2025-01-30 15:40:13 UTC
My bad, I set incorrect NEEDINFO. Fixing

Comment 6 Marc-Andre Lureau 2025-01-30 20:56:00 UTC
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-picky/rust-picky.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08588191/rust-picky-7.0.0~rc.12-1.src.rpm
Description: Portable X.509, PKI, JOSE and HTTP signature implementation.
Fedora Account System Username: elmarco

Comment 7 Cole Robinson 2025-02-02 15:38:01 UTC
There's some install problems with optional dependencies:

Problem 1: conflicting requests
  - nothing provides (crate(cab/default) >= 0.6.0 with crate(cab/default) < 0.7.0~) needed by rust-picky+ctl_http_fetch-devel-7.0.0~rc.12-1.fc42.noarch from @commandline
 Problem 2: conflicting requests
  - nothing provides (crate(lexical-sort/default) >= 0.3.0 with crate(lexical-sort/default) < 0.4.0~) needed by rust-picky+ssh-devel-7.0.0~rc.12-1.fc42.noarch from @commandline
 Problem 3: package rust-picky+putty-devel-7.0.0~rc.12-1.fc42.noarch from @commandline requires crate(picky/ssh) = 7.0.0~rc.12, but none of the providers can be installed
  - conflicting requests
  - nothing provides (crate(lexical-sort/default) >= 0.3.0 with crate(lexical-sort/default) < 0.4.0~) needed by rust-picky+ssh-devel-7.0.0~rc.12-1.fc42.noarch from @commandline


Do any of your uses need ctl_http_fetch, ssh, or putty features?
If not you can patch them out.
Use `rust2rpm --patch` to interactively generate a patch and rip out the [features] sections, and the lexical-sort and cab dependency sections.
Then I'd suggest renaming that patch, stuffing it into rust2rpm.toml extra-patches section, with a comment
describing the change. Example: https://bugzilla.redhat.com/show_bug.cgi?id=2332550#c3

If you go the rust2rpm.toml route, please also provide that in next update, so I can regenerate the package myself.

Comment 8 Marc-Andre Lureau 2025-02-03 10:18:58 UTC
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-picky/rust-picky.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08600730/rust-picky-7.0.0~rc.12-1.src.rpm
Description: Portable X.509, PKI, JOSE and HTTP signature implementation.
Fedora Account System Username: elmarco

> Do any of your uses need ctl_http_fetch, ssh, or putty features?
> If not you can patch them out.

done

I used [features] hide =... which seems to be better for this case.

See https://github.com/elmarco/ironrdp-fedora/tree/master/rust-picky

Comment 9 Cole Robinson 2025-02-03 20:03:19 UTC
(In reply to Marc-Andre Lureau from comment #8)
> 
> I used [features] hide =... which seems to be better for this case.
> 
> See https://github.com/elmarco/ironrdp-fedora/tree/master/rust-picky

ooo yeah, that's much nicer.

Looks good to me now and everything is installing correctly.
Setting fedora-review+

Comment 10 Cole Robinson 2025-02-09 16:52:47 UTC
This was addressed in bug 2343680

*** This bug has been marked as a duplicate of bug 2343680 ***