Bug 2329181 (rust-sspi) - Review Request: rust-sspi - Rust implementation of the Security Support Provider Interface
Summary: Review Request: rust-sspi - Rust implementation of the Security Support Provi...
Keywords:
Status: CLOSED ERRATA
Alias: rust-sspi
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Cole Robinson
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/sspi
Whiteboard:
Depends On: rust-picky rust-md4 2336864 2343680 rust-picky-krb 2346938
Blocks: rust-ironrdp-connector
TreeView+ depends on / blocked
 
Reported: 2024-11-27 17:51 UTC by Marc-Andre Lureau
Modified: 2025-03-04 18:59 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-03-04 18:59:52 UTC
Type: ---
Embargoed:
crobinso: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 8702787 to 8704912 (2.31 KB, patch)
2025-02-27 08:38 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 8704912 to 8723100 (1.46 KB, patch)
2025-03-04 14:33 UTC, Fedora Review Service
no flags Details | Diff

Description Marc-Andre Lureau 2024-11-27 17:51:15 UTC
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-sspi/rust-sspi.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08318551/rust-sspi-0.15.0-1.src.rpm
Description: Rust implementation of the Security Support Provider Interface
Fedora Account System Username: elmarco

Comment 1 Fedora Review Service 2024-11-27 17:53:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8319583
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329181-rust-sspi/fedora-rawhide-x86_64/08319583-rust-sspi/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 danfrantes 2024-11-30 19:06:25 UTC
[fedora-review-service-build]

Comment 3 Fedora Review Service 2024-11-30 19:10:32 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8330105
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329181-rust-sspi/fedora-rawhide-x86_64/08330105-rust-sspi/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Cole Robinson 2025-02-09 16:55:08 UTC
I'll review this, but please update builds for latest 0.15.1 release

Comment 5 Marc-Andre Lureau 2025-02-20 09:38:50 UTC
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-sspi/rust-sspi.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08674717/rust-sspi-0.15.1-1.src.rpm
Description: Rust implementation of the Security Support Provider Interface
Fedora Account System Username: elmarco

Comment 6 Fedora Review Service 2025-02-20 15:44:58 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8675805
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329181-rust-sspi/fedora-rawhide-x86_64/08675805-rust-sspi/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Cole Robinson 2025-02-20 17:55:03 UTC
rawhide build is failing:

DEBUG util.py:459:  Problem: nothing provides requested (crate(picky-krb/default) >= 0.9.0 with crate(picky-krb/default) < 0.10.0~)

Comment 8 Marc-Andre Lureau 2025-02-21 06:58:56 UTC
added missing dep

Comment 9 Marc-Andre Lureau 2025-02-26 15:54:48 UTC
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-sspi/rust-sspi.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08674717/rust-sspi-0.15.1-1.src.rpm
Description: Rust implementation of the Security Support Provider Interface
Fedora Account System Username: elmarco

copr build succeeded (on x86 atm):
https://copr.fedorainfracloud.org/coprs/elmarco/qemu-rdp/build/8702701/

Comment 10 Fedora Review Service 2025-02-26 16:30:16 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8702787
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329181-rust-sspi/fedora-rawhide-x86_64/08702787-rust-sspi/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 11 Cole Robinson 2025-02-27 00:14:59 UTC
This still has install issues:

Problem 1: conflicting requests
  - nothing provides (crate(rustls/aws-lc-rs) >= 0.23.0 with crate(rustls/aws-lc-rs) < 0.24.0~) needed by rust-sspi+aws-lc-rs-devel-0.15.1-1.fc43.noarch from @commandline
 Problem 2: conflicting requests
  - nothing provides (crate(winscard/default) >= 0.2.0 with crate(winscard/default) < 0.3.0~) needed by rust-sspi+scard-devel-0.15.1-1.fc43.noarch from @commandline
You can try to add to command line:
  --skip-broken to skip uninstallable packages

The generated package list looks weird too:

# ls
rust-sspi-0.15.1-1.fc43.src.rpm
rust-sspi+aws-lc-rs-devel-0.15.1-1.fc43.noarch.rpm
rust-sspi+default-devel-0.15.1-1.fc43.noarch.rpm
rust-sspi-devel-0.15.1-1.fc43.noarch.rpm
rust-sspi+dns_resolver-devel-0.15.1-1.fc43.noarch.rpm
rust-sspi+__install-crypto-provider-devel-0.15.1-1.fc43.noarch.rpm
rust-sspi+network_client-devel-0.15.1-1.fc43.noarch.rpm
rust-sspi+ring-devel-0.15.1-1.fc43.noarch.rpm
rust-sspi+__rustls-used-devel-0.15.1-1.fc43.noarch.rpm
rust-sspi+scard-devel-0.15.1-1.fc43.noarch.rpm
rust-sspi+__test-data-devel-0.15.1-1.fc43.noarch.rpm
rust-sspi+tsssp-devel-0.15.1-1.fc43.noarch.rpm

Notice the double underscore packages, that seems wrong but I didn't dig into it
Package could also use rust2rpm.toml with a comment for the manual metadata change

Comment 12 Marc-Andre Lureau 2025-02-27 08:10:19 UTC
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-sspi/rust-sspi.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08704880/rust-sspi-0.15.1-1.src.rpm
Description: Rust implementation of the Security Support Provider Interface
Fedora Account System Username: elmarco

thanks

Comment 13 Fedora Review Service 2025-02-27 08:38:14 UTC
Created attachment 2078015 [details]
The .spec file difference from Copr build 8702787 to 8704912

Comment 14 Fedora Review Service 2025-02-27 08:38:16 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8704912
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329181-rust-sspi/fedora-rawhide-x86_64/08704912-rust-sspi/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 15 Cole Robinson 2025-02-27 16:28:52 UTC
Something still ain't right, installing all subpackages is failing on rawhide. Please confirm install is working before posting new builds

You can use a section like this in rust2rpm.toml to avoid the $EDITOR drop in

[package]
extra-patches = [
  { number = 10, file = "sspi-fix-metadata.diff", comments = ["default to the ring crypto backend"] }
]

Comment 16 Fabio Valentini 2025-03-03 20:57:56 UTC
> [package]
> extra-patches = [
>   { number = 10, file = "sspi-fix-metadata.diff", comments = ["default to the ring crypto backend"] }
> ]

For the record, extra-patches is for patches *other* than those touching Cargo.toml.

To persist those changes, use

"""
[package]
cargo-toml-patch-comments = ["default to the ring crypto backend"]
"""

in conjunction with "rust2rpm --reuse-patch", instead.

Comment 17 Marc-Andre Lureau 2025-03-04 14:01:11 UTC
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-sspi/rust-sspi.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08723076/rust-sspi-0.15.2-1.src.rpm
Description: Rust implementation of the Security Support Provider Interface
Fedora Account System Username: elmarco

Comment 18 Fedora Review Service 2025-03-04 14:33:11 UTC
Created attachment 2078860 [details]
The .spec file difference from Copr build 8704912 to 8723100

Comment 19 Fedora Review Service 2025-03-04 14:33:13 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8723100
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329181-rust-sspi/fedora-rawhide-x86_64/08723100-rust-sspi/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 20 Cole Robinson 2025-03-04 15:04:02 UTC
(In reply to Fabio Valentini from comment #16)
> > [package]
> > extra-patches = [
> >   { number = 10, file = "sspi-fix-metadata.diff", comments = ["default to the ring crypto backend"] }
> > ]
> 
> For the record, extra-patches is for patches *other* than those touching
> Cargo.toml.

Ok noted, thanks. Does it trigger different behavior?

Comment 21 Cole Robinson 2025-03-04 15:28:58 UTC
* spec content matches rust2rpm.toml output (and it's correctly using --reuse-patch like suggested)
* builds on rawhide
* installs on rawhide
* content looks fine

setting fedora-review+

The underscore in crate names still seem weird but that's just how the upstream package is arranged apparently...

Comment 22 Fedora Admin user for bugzilla script actions 2025-03-04 18:38:41 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sspi

Comment 23 Fedora Update System 2025-03-04 18:54:36 UTC
FEDORA-2025-b6423389be (rust-sspi-0.15.2-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-b6423389be

Comment 24 Fedora Update System 2025-03-04 18:59:52 UTC
FEDORA-2025-b6423389be (rust-sspi-0.15.2-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.