Bug 1881611

Summary:	Review Request: golang-github-projectdiscovery-httpx - Fast and multi-purpose HTTP toolkit
Product:	[Fedora] Fedora	Reporter:	Fabian Affolter <mail>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, mattia.verga, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-12-10 16:54:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1880691, 1881572, 1881585, 1881589, 1881604, 1881612
Bug Blocks:

Description Fabian Affolter 2020-09-22 18:23:37 UTC

Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-projectdiscovery-httpx.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-projectdiscovery-httpx-1.0.2-1.fc32.src.rpm

Project URL: https://github.com/projectdiscovery/httpx

Description:
Httpx is a fast and multi-purpose HTTP toolkit allow to run multiple probers
using retryablehttp library, it is designed to maintain the result reliability
with increased threads.

Koji scratch build:
fails due to missing dependencies

rpmlint output:
$ rpmlint golang-github-projectdiscovery-httpx-1.0.2-1.fc32.src.rpm 
golang-github-projectdiscovery-httpx.src: W: spelling-error %description -l en_US probers -> probes, probe's, probe rs
golang-github-projectdiscovery-httpx.src: W: spelling-error %description -l en_US retryablehttp -> regrettable
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint golang-github-projectdiscovery-httpx-devel-1.0.2-1.fc32.noarch.rpm 
golang-github-projectdiscovery-httpx-devel.noarch: W: spelling-error %description -l en_US probers -> probes, probe's, probe rs
golang-github-projectdiscovery-httpx-devel.noarch: W: spelling-error %description -l en_US retryablehttp -> regrettable
golang-github-projectdiscovery-httpx-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/projectdiscovery/httpx/.goipath
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-11-04 11:01:58 UTC

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 2 Fabian Affolter 2020-11-08 14:18:49 UTC

Thanks for the review.

Comment 3 Gwyn Ciesla 2020-11-30 14:24:40 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-projectdiscovery-httpx

Comment 4 Mattia Verga 2021-12-17 17:05:42 UTC

The package was never imported, Fabian are you still interested in finalizing the submission?

Comment 5 Package Review 2022-12-10 16:54:07 UTC

Package is now in repositories, closing review.