Bug 1881612 - Review Request: golang-github-coocood-freecache - Cache library with zero GC overhead
Summary: Review Request: golang-github-coocood-freecache - Cache library with zero GC ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1881611
TreeView+ depends on / blocked
 
Reported: 2020-09-22 18:23 UTC by Fabian Affolter
Modified: 2020-11-28 02:03 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-28 02:03:35 UTC
Type: Bug
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Fabian Affolter 2020-09-22 18:23:45 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-coocood-freecache.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-coocood-freecache-1.1.1-1.fc32.src.rpm

Project URL: https://github.com/coocood/freecache

Description:
A cache library for Go with zero GC overhead.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=52036450

rpmlint output:
$ rpmlint golang-github-coocood-freecache-1.1.1-1.fc32.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint golang-github-coocood-freecache-devel-1.1.1-1.fc32.noarch.rpm 
golang-github-coocood-freecache-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/coocood/freecache/.goipath
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-11-04 10:55:05 UTC
 - Please rename the command, server is too generic:

%build
for cmd in server; do
  %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
done


Not sure it's even useful to provide it, it's more an example than anything.

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Fix the name thingie before import.

Comment 2 Fabian Affolter 2020-11-18 07:31:42 UTC
Thanks for the review.

Comment 3 Gwyn Ciesla 2020-11-18 14:29:08 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-coocood-freecache

Comment 4 Fedora Update System 2020-11-19 15:23:40 UTC
FEDORA-2020-07f53fe022 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-07f53fe022

Comment 5 Fedora Update System 2020-11-20 02:15:14 UTC
FEDORA-2020-07f53fe022 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-07f53fe022 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-07f53fe022

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2020-11-28 02:03:35 UTC
FEDORA-2020-07f53fe022 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.