Bug 1882999
| Summary: | Review Request: R-lpSolve - Interface to Lp_solve to Solve Linear/Integer Programs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Elliott Sales de Andrade <quantum.analyst> |
| Component: | Package Review | Assignee: | José Matos <jamatos> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jamatos, package-review |
| Target Milestone: | --- | Flags: | jamatos:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | R-lpSolve-5.6.15-1.fc34 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-10-05 00:17:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1883047 | ||
|
Description
Elliott Sales de Andrade
2020-09-27 10:23:12 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=52348240 The license is correct and appropriated for Fedora. The spec file follows the Fedora package guidelines. In this cases these are the fedora-review complaints: Issues: ======= - Package have the default element marked as %%doc :DESCRIPTION - Package requires R-core. - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ The first is a bug as DESCRIPTION is not marked as %doc and the others are as intended. I must confess that I found the description puzzling due to the last sentence. "This version calls lp_solve version 5.5." My problem is with "calls" this is very overloaded here. Essentially R-lpSolve has a copy of lp_Solve and provides an R interface to it. Since the code is 15 years old I think that it is OK. "Although practicality beats purity." (Zen of Python) So the package is approved.  (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-lpSolve FEDORA-2020-7d3e8189f1 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7d3e8189f1 FEDORA-2020-e15eb4fc79 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e15eb4fc79 FEDORA-2020-6e5f3336b7 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-6e5f3336b7 FEDORA-2020-7d3e8189f1 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-7d3e8189f1` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7d3e8189f1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-6e5f3336b7 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-6e5f3336b7` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-6e5f3336b7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-e15eb4fc79 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-e15eb4fc79` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e15eb4fc79 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-7d3e8189f1 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-e15eb4fc79 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-6e5f3336b7 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. |