Bug 1882999 - Review Request: R-lpSolve - Interface to Lp_solve to Solve Linear/Integer Programs
Summary: Review Request: R-lpSolve - Interface to Lp_solve to Solve Linear/Integer Pro...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1883047
TreeView+ depends on / blocked
 
Reported: 2020-09-27 10:23 UTC by Elliott Sales de Andrade
Modified: 2020-10-09 15:01 UTC (History)
2 users (show)

Fixed In Version: R-lpSolve-5.6.15-1.fc34
Clone Of:
Environment:
Last Closed: 2020-10-05 00:17:02 UTC
Type: ---
Embargoed:
jamatos: fedora-review+


Attachments (Terms of Use)

Description Elliott Sales de Andrade 2020-09-27 10:23:12 UTC
Spec URL: https://qulogic.fedorapeople.org//R-lpSolve.spec
SRPM URL: https://qulogic.fedorapeople.org//R-lpSolve-5.6.15-1.fc32.src.rpm

Description:
Lp_solve is freely available (under LGPL 2) software for solving linear,
integer and mixed integer programs. In this implementation we supply a
"wrapper" function in C and some R functions that solve general
linear/integer problems, assignment problems, and transportation problems.
This version calls lp_solve version 5.5.

Comment 1 Elliott Sales de Andrade 2020-09-27 10:23:14 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=52348240

Comment 2 José Matos 2020-09-30 08:58:17 UTC
The license is correct and appropriated for Fedora. The spec file follows the
Fedora package guidelines.

In this cases these are the fedora-review complaints:

Issues:
=======
- Package have the default element marked as %%doc :DESCRIPTION
- Package requires R-core.
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

The first is a bug as DESCRIPTION is not marked as %doc and the others are as
intended.

I must confess that I found the description puzzling due to the last sentence.
"This version calls lp_solve version 5.5."

My problem is with "calls" this is very overloaded here.
Essentially R-lpSolve has a copy of lp_Solve and provides an R interface to it.
Since the code is 15 years old I think that it is OK. "Although practicality beats purity." (Zen of Python)

So the package is approved. 

Comment 3 Gwyn Ciesla 2020-09-30 19:01:58 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/R-lpSolve

Comment 4 Fedora Update System 2020-09-30 23:14:51 UTC
FEDORA-2020-7d3e8189f1 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7d3e8189f1

Comment 5 Fedora Update System 2020-09-30 23:15:00 UTC
FEDORA-2020-e15eb4fc79 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e15eb4fc79

Comment 6 Fedora Update System 2020-09-30 23:15:09 UTC
FEDORA-2020-6e5f3336b7 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-6e5f3336b7

Comment 7 Fedora Update System 2020-10-01 01:20:58 UTC
FEDORA-2020-7d3e8189f1 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-7d3e8189f1`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7d3e8189f1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2020-10-01 01:30:08 UTC
FEDORA-2020-6e5f3336b7 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-6e5f3336b7`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-6e5f3336b7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2020-10-01 02:15:52 UTC
FEDORA-2020-e15eb4fc79 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-e15eb4fc79`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e15eb4fc79

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2020-10-05 00:17:02 UTC
FEDORA-2020-7d3e8189f1 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2020-10-09 15:01:02 UTC
FEDORA-2020-e15eb4fc79 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2020-10-09 15:01:03 UTC
FEDORA-2020-6e5f3336b7 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.