Bug 1883047

Summary: Review Request: R-pak - Another Approach to Package Installation
Product: [Fedora] Fedora Reporter: Elliott Sales de Andrade <quantum.analyst>
Component: Package ReviewAssignee: José Matos <jamatos>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jamatos, package-review
Target Milestone: ---Flags: jamatos: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: R-pak-0.1.2-2.fc34 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-05 00:17:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1882978, 1882999    
Bug Blocks: 1877265    

Description Elliott Sales de Andrade 2020-09-27 21:14:44 UTC
Spec URL: https://qulogic.fedorapeople.org//R-pak.spec
SRPM URL: https://qulogic.fedorapeople.org//R-pak-0.1.2-1.fc32.src.rpm

Description:
The goal of 'pak' is to make package installation faster and more reliable.
In particular, it performs all HTTP operations in parallel, so metadata
resolution and package downloads are fast. Metadata and package files are
cached on the local disk as well. 'pak' has a dependency solver, so it
finds version conflicts before performing the installation. This version of
'pak' supports CRAN, 'Bioconductor' and 'GitHub' packages as well.

Comment 1 José Matos 2020-09-30 09:39:47 UTC
The license is correct and appropriated for Fedora. The spec file follows the
Fedora package guidelines.

In this cases these are the fedora-review complaints:

Issues:
=======
- Package have the default element marked as %%doc :DESCRIPTION
- Package requires R-core.
- Package installs properly.

The first two are usual and are not issues.
The last one is more interesting, for a suitable definition of interesting. :-)

It fails with the following error:
Error:
 Problem: conflicting requests
  - nothing provides R(rprojroot) >= 1.3.2 needed by R-pak-0.1.2-1.fc34.noarch

Actually consulting https://src.fedoraproject.org/rpms/R-rprojroot there is no build for rawhide (F34).

And yet asking to if the package is in rawhide:
# dnf -q list R-rprojroot --disablerepo=\* --enablerepo=rawhide
Available Packages
R-rprojroot.noarch              1.3.2-9.fc33                   rawhide

So this is a non-issue.

The package is approved.

Comment 2 José Matos 2020-09-30 13:06:50 UTC
After a thread in fedora-devel the cause become evident:

# dnf -q repoquery --provides R-rprojroot --disablerepo=\* --enablerepo=rawhide
R(rprojroot) = 1.3-2
R-rprojroot = 1.3.2-9.fc33

Notice that dash instead of the dot in "R(rprojroot) = 1.3-2".

Probably this is a bug in the rpm R macros, no?

Comment 3 Elliott Sales de Andrade 2020-09-30 18:51:43 UTC
This is a bug in the pak metadata; it should say 1.3-2. I will send a patch upstream.

Comment 4 Gwyn Ciesla 2020-09-30 19:02:45 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/R-pak

Comment 5 Fedora Update System 2020-09-30 23:14:54 UTC
FEDORA-2020-7d3e8189f1 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7d3e8189f1

Comment 6 Fedora Update System 2020-09-30 23:15:02 UTC
FEDORA-2020-e15eb4fc79 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e15eb4fc79

Comment 7 Fedora Update System 2020-09-30 23:15:11 UTC
FEDORA-2020-6e5f3336b7 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-6e5f3336b7

Comment 8 Fedora Update System 2020-10-01 01:21:00 UTC
FEDORA-2020-7d3e8189f1 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-7d3e8189f1`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7d3e8189f1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2020-10-01 01:30:10 UTC
FEDORA-2020-6e5f3336b7 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-6e5f3336b7`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-6e5f3336b7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2020-10-01 02:15:53 UTC
FEDORA-2020-e15eb4fc79 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-e15eb4fc79`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e15eb4fc79

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2020-10-05 00:17:05 UTC
FEDORA-2020-7d3e8189f1 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2020-10-09 15:01:04 UTC
FEDORA-2020-e15eb4fc79 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2020-10-09 15:01:05 UTC
FEDORA-2020-6e5f3336b7 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.