Bug 188429
Summary: | Review Request: glib | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
Component: | Package Review | Assignee: | Ville Skyttä <scop> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | bugs.michael |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-04-24 14:34:41 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 188430 |
Description
Rex Dieter
2006-04-09 17:36:54 UTC
* rpmlint messages needing action: E: glib non-utf8-spec-file glib.spec --> use eg. iconv to convert it (from iso-8859-1, I guess) W: glib unstripped-binary-or-object /usr/lib64/libgmodule-1.2.so.0.0.10 --> executable bits missing * %description (the last sentence) could be updated considering that glib 1.x is legacy stuff, "will depend" is a bit bold a statement nowadays :) * "|| :" at end of %check is superfluous --- glib.spec.orig 2006-04-09 04:20:56.000000000 +0200 +++ glib.spec 2006-04-12 09:36:12.000000000 +0200 @@ -59,7 +59,7 @@ rm -rf $RPM_BUILD_ROOT%{_infodir} rm -f $RPM_BUILD_ROOT%{_libdir}/lib*.la -#chmod a+x $RPM_BUILD_ROOT%{_libdir}/*.so +chmod a+x $RPM_BUILD_ROOT%{_libdir}/*.so.* %clean * Wed Apr 12 2006 Rex Dieter <rexdieter[AT]users.sf.net> 1:1.2.10-20 - cleanup %%description - libgmodule-1.2.so.0* missing eXecute bit - utf-8'ize specfile I chose to keep the %check ||:, since this is a legacy pkg afterall, and it certainly doesn't hurt anything. Spec Name or Url: http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/glib-1.2.10-20.spec SRPM Name or Url: http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.stable/glib-1.2.10-20.src.rpm Sorry for the delay, I don't remember seeing bugmails about the progress made here. 1.2.10-20 looks good, approved. (Even though glib is legacy stuff, this particular package probably won't ever enter < FC6, so the "|| :" is indeed very much superfluous...) Thanks, imported. |