Red Hat Bugzilla – Bug 188430
Review Request: gtk+
Last modified: 2007-11-30 17:11:30 EST
Spec Name or Url: http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/gtk+-1.2.10-51.spec SRPM Name or Url: http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.stable/gtk+-1.2.10-51.src.rpm Description: The gtk+ package contains the GIMP ToolKit (GTK+), a library for creating graphical user interfaces for the X Window System. GTK+ was originally written for the GIMP (GNU Image Manipulation Program) image processing program, but is now used by several other programs as well. Removed from devel/fc6 Core, intended for (fc6 only) Extras. %changelog * Sat Apr 08 2006 Rex Dieter <rexdieter[AT]users.sf.net 1:1.2.10-51 - cleanup for Extras - drop Obsoletes: gtk (that must be *way* old) - drop gdk-pixbuf debpendancy - fix/re-enable gdkgtkdep patch - no_undefined patch
Please add any dependencies here so it is clear which order we need to approve and build things.
Skimming diffs only so far, random findings or comments: - The %if "%{?fedora}" > "4" conditionals can be dropped for a FC6+ only package - %check belongs logically after %install, especially if you insist on keeping the "|| :" in it too to support old distro versions - Does the test suite work in "headless" build environments? What about mock? - Rationale for 444 perms for /etc/gtk/gtkrc? I believe 644 would do just fine - Possibly unowned %{_datadir}/themes dir (I haven't checked the dep tree) - specfile not UTF-8
(yes, gtk+ builds fine in mock, that's how I found out about the modular_x dependancies the hard way...) %changelog * Mon Apr 24 2006 Rex Dieter <rexdieter[AT]users.sf.net> 1:1.2.10-52 - install -m644 gtkrc ... - utf-8 specfile - comment %%fedora > 4 constructs - own %%_datadir/themes - move %%check after %%install Spec Name or Url: http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/gtk+-1.2.10-52.spec SRPM Name or Url: http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.stable/gtk+-1.2.10-52.src.rpm
Looks ok to me, just one final clarification: The no-undefined patch is there just to help ensure that no undefined non-weak symbols sneak out in the libs later? The gtkgdkdep patch already results in libgtk being linked with libgdk and takes care of them in this case, no? FWIW, in case you didn't notice, glib has some undefined symbols as well in libgmodule-1.2.so.0.0.10 and libgthread-1.2.so.0.0.10.
Re: no-undefined patch. You're right. It's just to guarantee no future goofs. Re: glib undefined symbols... hmm... I thought I had checked that, but it appears I only checked libglib, not the others. Should be easy enough to fix. Are we a go here then (APPROVED)?
Yep, approved, I just wanted to make sure I understand what the no-undefined patch is for.
Thanks, imported (build pending buildsys/devel working again).