Bug 188484

Summary: gnome-sudoku fails to build because of rpm spec file errors
Product: [Fedora] Fedora Reporter: Prarit Bhargava <prarit>
Component: gnome-sudokuAssignee: Paul W. Frields <stickster>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 5CC: extras-qa
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-04-13 11:38:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163350    
Attachments:
Description Flags
Patch to fix %if typos in gnome-sudoku rpm spec file none

Description Prarit Bhargava 2006-04-10 15:34:04 UTC
Description of problem:  
  
gnome-sudoku fails to build because of rpm spec file errors.  There are two  
issues, the first is incorrect %if statements, and the second is a missing  
patch.  
  
Version-Release number of selected component (if applicable):  
  
gnome-sudoku-0.4.0-5.fc5.src.rpm  
  
How reproducible: 100%  
  
  
Steps to Reproduce:  
1. rpmbuild --rebuild source RPM or rpmbuild -bb spec.file  
    
Actual results: RPM fails to build  
  
  
Expected results: RPM should build  
 
Additional info: A patch to fix the %if statements is in this BZ, however, I 
do not have CVS access to fix the issue with the missing .patch file ...

Comment 1 Prarit Bhargava 2006-04-10 15:34:05 UTC
Created attachment 127552 [details]
Patch to fix %if typos in gnome-sudoku rpm spec file

Comment 2 Paul Howarth 2006-04-10 16:05:17 UTC
The patch is missing because you've picked up an FC5/rawhide version of the SRPM,
which doesn't include the patch since it isn't needed there.

The SRPM would be more portable if it included the patch file in the SRPM
unconditionally and just used the %{fedora} macro to decide whether or not to
apply the patch.


Comment 3 Prarit Bhargava 2006-04-10 17:11:34 UTC
>The patch is missing because you've picked up an FC5/rawhide version of the  
SRPM,  
which doesn't include the patch since it isn't needed there.  
  
Ok, but I'm building on a system with   
  
[root@altix2 SPECS]# rpm -q fedora-release  
fedora-release-5.89-rawhide  
  
Is there another RPM package I need to update such that  
%{fedora} resolves correctly?  
  
>The SRPM would be more portable if it included the patch file in the SRPM 
unconditionally and just used the %{fedora} macro to decide whether or not to 
apply the patch. 
  
IMO, that's probably a better way to do it ... 
 
P.