Description of problem: gnome-sudoku fails to build because of rpm spec file errors. There are two issues, the first is incorrect %if statements, and the second is a missing patch. Version-Release number of selected component (if applicable): gnome-sudoku-0.4.0-5.fc5.src.rpm How reproducible: 100% Steps to Reproduce: 1. rpmbuild --rebuild source RPM or rpmbuild -bb spec.file Actual results: RPM fails to build Expected results: RPM should build Additional info: A patch to fix the %if statements is in this BZ, however, I do not have CVS access to fix the issue with the missing .patch file ...
Created attachment 127552 [details] Patch to fix %if typos in gnome-sudoku rpm spec file
The patch is missing because you've picked up an FC5/rawhide version of the SRPM, which doesn't include the patch since it isn't needed there. The SRPM would be more portable if it included the patch file in the SRPM unconditionally and just used the %{fedora} macro to decide whether or not to apply the patch.
>The patch is missing because you've picked up an FC5/rawhide version of the SRPM, which doesn't include the patch since it isn't needed there. Ok, but I'm building on a system with [root@altix2 SPECS]# rpm -q fedora-release fedora-release-5.89-rawhide Is there another RPM package I need to update such that %{fedora} resolves correctly? >The SRPM would be more portable if it included the patch file in the SRPM unconditionally and just used the %{fedora} macro to decide whether or not to apply the patch. IMO, that's probably a better way to do it ... P.