Bug 1885792

There's a bug in f33-backgrounds-33.0.6-1.fc33 . /usr/share/backgrounds/f33/default/f33.png is a symlink, and it's broken:

[root@xps13k tmp]# ls /usr/share/backgrounds/f33/default/f33.png -l
lrwxrwxrwx. 1 root root 24 Oct  5 18:33 /usr/share/backgrounds/f33/default/f33.png -> ./default/f33-02-day.png

note that the target is ./default/f33-02-day.png , with a single period. It's supposed to be ../default/f33-02-day.png , with two periods.

The symlink is created by a Makefile, and the problem is a stray dollar sign. The offending commit is this one:

https://github.com/fedoradesign/backgrounds/commit/1d5915fc77eb217ca59fdc2d1a6fc4c7b813b18c

Luya made the same change on both master branch and f33-backgrounds branch. On master branch it was done right, but on f33-backgrounds branch he left the dollar sign in accidentally, so the line reads:

$(LN_S) $../default/$(WP_NAME)-02-day.png	$(WP_DIR)/default/$(WP_NAME).png

what that actually *runs* during the package build is:

/bin/ln -s ./default/f33-02-day.png	/builddir/build/BUILDROOT/f33-backgrounds-33.0.6-1.fc33.noarch/usr/share/backgrounds/f33/default/f33.png

..and so the symlink winds up broken. The fix is simply to drop the dollar sign. I'll send a PR.

This is a clear Final blocker because it means the background on KDE (a release blocking desktop) is a black screen. It doesn't quite hit the automatic blocker rules, though, so I'm just proposing it as a blocker per Final criterion "The proposed final Fedora artwork must be included and used as the background on release-blocking desktops".