Bug 1886561

I have made a PR that attempts to fix this: https://src.fedoraproject.org/rpms/nano/pull-request/3

Proposed as a Freeze Exception for 33-final by Fedora user chrismurphy using the blocker tracking app because:

 Lack of syntax highlighting can be slightly aggravating, and nano is now the default editor. While it can be fixed with an update, it's preferred that the problem isn't happening on all our media.

FEDORA-2020-49d1a285d5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-49d1a285d5

FEDORA-2020-49d1a285d5 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-49d1a285d5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-49d1a285d5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Neal Gompa, I find it inappropriate that you directly pushed your changes immediately after opening the pull request, without giving anybody chance to comment on this.  You are not listed as member at https://src.fedoraproject.org/rpms/nano/ so you should discuss non-trivial changes with maintainers before pushing them directly.

(In reply to Kamil Dudka from comment #5)
> Neal Gompa, I find it inappropriate that you directly pushed your changes
> immediately after opening the pull request, without giving anybody chance to
> comment on this.  You are not listed as member at
> https://src.fedoraproject.org/rpms/nano/ so you should discuss non-trivial
> changes with maintainers before pushing them directly.

I moved it and decided to merge it because it retains continuity of syntax highlight support from the previous versions shipped in Fedora 33 and older Fedora releases.

When the grammars were moved out to the `extra` directory in the 5.0 release, the notes[1] said the following:

> Distro-specific syntaxes, and syntaxes of less common languages,
> have been moved down to subdirectory syntax/extra/. The affected
> distros and others may wish to move wanted syntaxes one level up.

To me, that says that we _should_ just move it back up.

[1]: https://www.nano-editor.org/news.php

This is not an excuse.  To me, this looks like misuse of your provenpackager privileges.  See the Policy for provenpackagers:

    "They should be careful not to change other people’s packages needlessly and try to do the minimal changes required to fix problems, ..."

I do not think this was so urgent that the changes could not be reviewed before pushing them.

(In reply to Kamil Dudka from comment #7)
> This is not an excuse.  To me, this looks like misuse of your provenpackager
> privileges.  See the Policy for provenpackagers:
> 
>     "They should be careful not to change other people’s packages needlessly
> and try to do the minimal changes required to fix problems, ..."
> 
> I do not think this was so urgent that the changes could not be reviewed
> before pushing them.

Perhaps you're right. I made a judgement call based on trying to ensure that this would be on the media and in the live environments. It probably could have waited a couple of days.

This is fixed by update

Discussed during the 2020-10-12 blocker review meeting: [0]

The decision to classify this bug as an "AcceptedFreezeException (Final)" was made as it is a noticeable issue that cannot be fixed with an update.

[0] https://meetbot.fedoraproject.org/fedora-blocker-review/2020-10-12/f33-blocker-review.2020-10-12-16.00.txt

Kamil: before we push this update, can we ask you to say whether you agree or disagree with the change, disregarding provenpackager process issues? Thanks!

FWIW, I think the change makes sense, I've read the upstream commit messages and thread and don't really buy the rationale for moving these syntaxes at all. The only justification upstream seemed to provide is that they somehow "burden" nano, but I don't see how at all. If you don't edit files of the relevant type they don't bother you, and if you do, highlighting is good.

Adam, please feel free to push the update.  The problem I pointed out can be fixed by a subsequent update if needed.

FEDORA-2020-49d1a285d5 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.