Bug 188677
| Summary: | Review Request: gnome-utils | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Clasen <mclasen> |
| Component: | Package Review | Assignee: | David Cantrell <dcantrell> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-04-19 17:45:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 188268 | ||
|
Description
Matthias Clasen
2006-04-12 01:58:12 UTC
rpmlint fails. Haven't looked much past this: W: gnome-utils summary-ended-with-dot GNOME utility programs. W: gnome-utils incoherent-version-in-changelog 2.14.0-5 2.14.0-2 E: gnome-utils binary-or-shlib-defines-rpath /usr/bin/gnome-dictionary ['/usr/lib64'] E: gnome-utils binary-or-shlib-defines-rpath /usr/libexec/gnome-dictionary-applet ['/usr/lib64'] W: gnome-utils non-conffile-in-etc /etc/gconf/schemas/gnome-search-tool.schemas W: gnome-utils non-conffile-in-etc /etc/gconf/schemas/logview.schemas W: gnome-utils non-conffile-in-etc /etc/security/console.apps/gnome-system-log W: gnome-utils devel-file-in-non-devel-package /usr/include/gdict-1.0/gdict/gdict-utils.h W: gnome-utils devel-file-in-non-devel-package /usr/lib64/pkgconfig/gdict-1.0.pc W: gnome-utils devel-file-in-non-devel-package /usr/include/gdict-1.0/gdict/gdict-source.h W: gnome-utils devel-file-in-non-devel-package /usr/include/gdict-1.0/gdict/gdict-entry.h W: gnome-utils devel-file-in-non-devel-package /usr/include/gdict-1.0/gdict/gdict-version.h W: gnome-utils devel-file-in-non-devel-package /usr/include/gdict-1.0/gdict/gdict-enum-types.h W: gnome-utils non-conffile-in-etc /etc/gconf/schemas/gnome-dictionary.schemas W: gnome-utils devel-file-in-non-devel-package /usr/include/gdict-1.0/gdict/gdict.h W: gnome-utils non-conffile-in-etc /etc/pam.d/gnome-system-log W: gnome-utils devel-file-in-non-devel-package /usr/include/gdict-1.0/gdict/gdict-context.h W: gnome-utils non-conffile-in-etc /etc/gconf/schemas/gnome-screenshot.schemas W: gnome-utils devel-file-in-non-devel-package /usr/include/gdict-1.0/gdict/gdict-source-loader.h W: gnome-utils no-dependency-on usermode W: gnome-utils devel-file-in-non-devel-package /usr/include/gdict-1.0/gdict/gdict-client-context.h W: gnome-utils devel-file-in-non-devel-package /usr/include/gdict-1.0/gdict/gdict-defbox.h W: gnome-utils devel-file-in-non-devel-package /usr/lib64/libgdict-1.0.so W: gnome-utils non-standard-dir-in-usr libexec E: gnome-utils shell-syntax-error-in-%post 32bit's only E's are the shell-syntax-error. E: gnome-utils binary-or-shlib-defines-rpath I didn't get this error. E: gnome-utils shell-syntax-error-in-%post I got this one, but I was not able to figure out what it complains about Regarding the warnings about conffiles and devel files, it is not clear to me that the /etc files listed here should be conffiles, and if we split off -libs and -devel packages on principle... We definitely don't split off -libs on principle and -devel is also questionable in cases where there really isn't a library being provided that we'd "want" people to develop against. We'll have to adjust the Packaging Guidelines and Review Guidelines regarding devel and lib packages. I can let those go through. I also don't know what its talking about for the error on x86_64, I'll try to get more info on that. And as far as the %post goes, if it executes w/out issues I think we can accept those too. Also missing: Requires(post): scrollkeeper, gconftool Requires(postun): desktop-file-utils, scrollkeeper Also, check out the guidelines concerning gconf usage: http://fedoraproject.org/wiki/ScriptletSnippets#head-ff64cd482595764f672082d5a3b83e1fc22962e8 You've also go some unnecessary BuildRequires. libX11-devel, glib2-devel, gtk2-devel, libgnome-devel, and libgnomeui-devel will all be pulled in by gnome-desktop-devel. Spec URL: http://people.redhat.com/mclasen/review/gnome-utils.spec SRPM URL: http://people.redhat.com/mclasen/review/gnome-utils-2.14.0-6.src.rpm now with -devel Changes sane. Approving. Devel package should have Requires: gnome-utils = %{version}-%{release},
instead of just %version.
fixed in the package thats now in rawhide |