Bug 1887343
| Summary: | Review Request: R-winch - Portable Native and Joint Stack Traces | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Elliott Sales de Andrade <quantum.analyst> |
| Component: | Package Review | Assignee: | José Matos <jamatos> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jamatos, package-review |
| Target Milestone: | --- | Flags: | jamatos:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-11-04 03:02:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1887041 | ||
| Bug Blocks: | |||
|
Description
Elliott Sales de Andrade
2020-10-12 08:09:49 UTC
The license is correct and appropriated for Fedora. The spec file follows the Fedora package guidelines. In this cases these are the fedora-review complaints: Issues: ======= - Package have the default element marked as %%doc :DESCRIPTION - Package requires R-core. - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ As usual these can be ignored. The particular case about this package is that it has been removed from CRAN because the tests fail on debin with clang, on solaris and on r-oldrel-windows-ix86+x86_64. These issues are in no a problem for Fedora. There are signs that a new version is on the works, probably fixing theses issues. Use your own judgment on how to proceed here. The package is approved. PS: The issue that I meant in the previous message is this: https://github.com/r-prof/winch/pull/39 Thank you for the review https://pagure.io/releng/fedora-scm-requests/issue/29950 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-winch FEDORA-2020-fc97d9188c has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-fc97d9188c FEDORA-2020-6c693766cb has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-6c693766cb FEDORA-2020-a758f5c171 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-a758f5c171 FEDORA-2020-6c693766cb has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-6c693766cb \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-6c693766cb See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-fc97d9188c has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-fc97d9188c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-fc97d9188c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-a758f5c171 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-a758f5c171 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a758f5c171 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-a758f5c171 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-fc97d9188c has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-6c693766cb has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. |