Bug 1887343 - Review Request: R-winch - Portable Native and Joint Stack Traces
Summary: Review Request: R-winch - Portable Native and Joint Stack Traces
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1887041
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-12 08:09 UTC by Elliott Sales de Andrade
Modified: 2020-11-04 04:01 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-04 03:02:01 UTC
Type: ---
Embargoed:
jamatos: fedora-review+


Attachments (Terms of Use)

Description Elliott Sales de Andrade 2020-10-12 08:09:49 UTC
Spec URL: https://qulogic.fedorapeople.org/reviews/R-winch/R-winch.spec
SRPM URL: https://qulogic.fedorapeople.org/reviews/R-winch/R-winch-0.0.1-1.fc32.src.rpm

Description:
Obtain the native stack trace and fuse it with R's stack trace for easier
debugging of R packages with native code.

Comment 1 José Matos 2020-10-23 18:49:57 UTC
The license is correct and appropriated for Fedora. The spec file follows the
Fedora package guidelines.

In this cases these are the fedora-review complaints:

Issues:
=======
- Package have the default element marked as %%doc :DESCRIPTION
- Package requires R-core.
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

As usual these can be ignored.

The particular case about this package is that it has been removed from CRAN because the tests fail on debin with clang, on solaris and on r-oldrel-windows-ix86+x86_64.

These issues are in no a problem for Fedora. There are signs that a new version is on the works, probably fixing theses issues. Use your own judgment on how to proceed here.
The package is approved.

Comment 2 José Matos 2020-10-23 18:51:05 UTC
PS: The issue that I meant in the previous message is this: https://github.com/r-prof/winch/pull/39

Comment 3 Elliott Sales de Andrade 2020-10-24 23:26:32 UTC
Thank you for the review

https://pagure.io/releng/fedora-scm-requests/issue/29950

Comment 4 Gwyn Ciesla 2020-10-25 22:17:01 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/R-winch

Comment 5 Fedora Update System 2020-10-26 22:42:13 UTC
FEDORA-2020-fc97d9188c has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-fc97d9188c

Comment 6 Fedora Update System 2020-10-26 22:42:15 UTC
FEDORA-2020-6c693766cb has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-6c693766cb

Comment 7 Fedora Update System 2020-10-26 22:42:17 UTC
FEDORA-2020-a758f5c171 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-a758f5c171

Comment 8 Fedora Update System 2020-10-27 02:23:18 UTC
FEDORA-2020-6c693766cb has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-6c693766cb \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-6c693766cb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2020-10-27 02:23:20 UTC
FEDORA-2020-fc97d9188c has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-fc97d9188c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-fc97d9188c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2020-10-27 02:37:59 UTC
FEDORA-2020-a758f5c171 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-a758f5c171 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a758f5c171

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2020-11-04 03:02:01 UTC
FEDORA-2020-a758f5c171 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2020-11-04 03:54:37 UTC
FEDORA-2020-fc97d9188c has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2020-11-04 04:01:52 UTC
FEDORA-2020-6c693766cb has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.