Bug 1888407

Summary: Flatpak updates and removals get confused if same ref occurs in multiple remotes
Product: Red Hat Enterprise Linux 8 Reporter: Owen Taylor <otaylor>
Component: gnome-softwareAssignee: Milan Crha <mcrha>
Status: CLOSED ERRATA QA Contact: Martin Krajnak <mkrajnak>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.3CC: jkoten, klember, mkrajnak, rhughes, tpelka, tpopela
Target Milestone: rcKeywords: Triaged
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: gnome-software-3.36.1-5.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-18 14:38:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch fixing the problem none

Description Owen Taylor 2020-10-14 18:59:00 UTC
Created attachment 1721558 [details]
Patch fixing the problem

If you have the same ref (com.redhat.Platform) in two remotes:

 * In a system remote, uninstalled
 * In a user remote, installed

Then trying to update or remove the installed package confuses GNOME Software because when processing the Flatpak transaction it looks up the *uninstalled* application rather than than installed application.

This was fixed piecemeal between 3.36 and 3.38 (https://gitlab.gnome.org/GNOME/gnome-software/-/commit/ae8f7e34cbc85174310849868f6bc61e6a3154ed and part of https://gitlab.gnome.org/GNOME/gnome-software/-/commit/dd100c88d0fe1dbdc271fb685cb34b5fe791c91c) 

I'll attach a patch here that has what is needed to fix this.

Comment 1 Milan Crha 2021-02-16 17:57:40 UTC
Thanks for the patch. I guess I can devel-ack it, due to the patch available.

Comment 7 errata-xmlrpc 2021-05-18 14:38:50 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: GNOME security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:1586