Bug 1888971
| Summary: | Review Request: golang-github-cli-shurcool-graphql - GraphQL client implementation | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Joe Doss <joe> |
| Component: | Package Review | Assignee: | Olivier Lemasle <o.lemasle> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 33 | CC: | o.lemasle, package-review |
| Target Milestone: | --- | Flags: | o.lemasle:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-11-06 14:24:40 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1888972 | ||
|
Description
Joe Doss
2020-10-16 16:10:48 UTC
What are your plans regarding this package? Retiring it when/if https://github.com/shurcooL/graphql/pull/57 is merged? I am going to retire it and build a the package for https://github.com/shurcooL/graphql and switch to that one. Please note that Fedora package for the upstream github.com/shurcooL/graphql already exists: https://src.fedoraproject.org/rpms/golang-github-shurcool-graphql So you will not have to build it. However, I am not totally comfortable with packaging a fork just for one patch; I feel it should be fixed in github-cli instead... But it seems to conform to Fedora packaging guidelines, so it's +1: - MIT license ok - Spec + changelog format ok - Naming guidelines + packaging guidelines ok - Builds in mock ok - Documentation ok Rpmlint ------- Checking: golang-github-cli-shurcool-graphql-devel-0-0.1.20201001git0f7232a.fc34.noarch.rpm golang-github-cli-shurcool-graphql-0-0.1.20201001git0f7232a.fc34.src.rpm golang-github-cli-shurcool-graphql-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/cli/shurcooL-graphql/.goipath golang-github-cli-shurcool-graphql.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- golang-github-cli-shurcool-graphql-devel.noarch: W: invalid-url URL: https://github.com/cli/shurcooL-graphql <urlopen error [Errno -3] Temporary failure in name resolution> golang-github-cli-shurcool-graphql-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/cli/shurcooL-graphql/.goipath 1 packages and 0 specfiles checked; 0 errors, 2 warnings. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-cli-shurcool-graphql |