Bug 1888971 - Review Request: golang-github-cli-shurcool-graphql - GraphQL client implementation
Summary: Review Request: golang-github-cli-shurcool-graphql - GraphQL client implement...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 33
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Olivier Lemasle
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1888972
TreeView+ depends on / blocked
 
Reported: 2020-10-16 16:10 UTC by Joe Doss
Modified: 2020-11-06 14:24 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-06 14:24:40 UTC
Type: Bug
Embargoed:
o.lemasle: fedora-review+


Attachments (Terms of Use)

Comment 1 Olivier Lemasle 2020-10-27 19:16:52 UTC
What are your plans regarding this package? Retiring it when/if https://github.com/shurcooL/graphql/pull/57 is merged?

Comment 2 Joe Doss 2020-10-27 19:59:07 UTC
I am going to retire it and build a the package for https://github.com/shurcooL/graphql and switch to that one.

Comment 3 Olivier Lemasle 2020-10-28 17:19:43 UTC
Please note that Fedora package for the upstream github.com/shurcooL/graphql already exists: https://src.fedoraproject.org/rpms/golang-github-shurcool-graphql
So you will not have to build it.

However, I am not totally comfortable with packaging a fork just for one patch; I feel it should be fixed in github-cli instead...

But it seems to conform to Fedora packaging guidelines, so it's +1:

- MIT license ok
- Spec + changelog format ok
- Naming guidelines + packaging guidelines ok
- Builds in mock ok
- Documentation ok



Rpmlint
-------
Checking: golang-github-cli-shurcool-graphql-devel-0-0.1.20201001git0f7232a.fc34.noarch.rpm
          golang-github-cli-shurcool-graphql-0-0.1.20201001git0f7232a.fc34.src.rpm
golang-github-cli-shurcool-graphql-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/cli/shurcooL-graphql/.goipath
golang-github-cli-shurcool-graphql.src: W: no-%build-section
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Rpmlint (installed packages)
----------------------------
golang-github-cli-shurcool-graphql-devel.noarch: W: invalid-url URL: https://github.com/cli/shurcooL-graphql <urlopen error [Errno -3] Temporary failure in name resolution>
golang-github-cli-shurcool-graphql-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/cli/shurcooL-graphql/.goipath
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Comment 4 Gwyn Ciesla 2020-10-28 21:31:14 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-cli-shurcool-graphql


Note You need to log in before you can comment on or make changes to this bug.