Bug 1889741

Summary: openshift4-cnf-test | Nodes where PTP agent is running are not detected properly (ptp daemonset)
Product: OpenShift Container Platform Reporter: Sebastian Scheinkman <sscheink>
Component: CNF Platform ValidationAssignee: Federico Paolinelli <fpaoline>
Status: VERIFIED --- QA Contact: Nikita <nkononov>
Severity: high Docs Contact:
Priority: high    
Version: 4.7CC: alosadag, aos-bugs, fpaoline, nkononov, omarzian
Target Milestone: ---   
Target Release: 4.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: 1889621 Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1889621    
Bug Blocks: 1889835    

Description Sebastian Scheinkman 2020-10-20 13:39:41 UTC
+++ This bug was initially created as a clone of Bug #1889621 +++

Description of problem:

PTP test did not pass because cnf-tests did not detect properly the number of nodes running PTP. 

Version-Release number of selected component (if applicable):

quay.io/openshift-kni/cnf-tests:latest

How reproducible:


Steps to Reproduce:
1. Configure the ptpOperatorConfig CRD to run only on a subset of nodes. For instance, nodes where the role label is equal to cnf-worker.
2. podman run -v $(pwd)/:/kubeconfig:Z -v $(pwd)/reports:/reports:Z -e KUBECONFIG=/kubeconfig/kubeconfig -e DISCOVERY_MODE=true quay.io/openshift-kni/cnf-tests:latest /usr/bin/test-run.sh /usr/bin/test-run.sh -ginkgo.focus="ptp"


Actual results:

• Failure [0.652 seconds]
[ptp]
/go/src/github.com/openshift-kni/cnf-features-deploy/vendor/github.com/openshift/ptp-operator/test/ptp/ptp.go:33
  PTP configuration verifications
  /go/src/github.com/openshift-kni/cnf-features-deploy/vendor/github.com/openshift/ptp-operator/test/ptp/ptp.go:38
    Should check that all nodes are running at least one replica of linuxptp-daemon [It]
    /go/src/github.com/openshift-kni/cnf-features-deploy/vendor/github.com/openshift/ptp-operator/test/ptp/ptp.go:61

    should be one instance per node
    Expected
        <int32>: 2
    to be ==
        <int>: 5


Expected results:

PASS since they are just two nodes selected to run the PTP agent.

Additional info:

The nodes where the PTP agent must run is configured in the ptpOperatorConfig CRD. As an example:

                apiVersion: ptp.openshift.io/v1
                kind: PtpOperatorConfig
                metadata:
                  name: default
                  namespace: openshift-ptp
                spec:
                  daemonNodeSelector:
                    node-role.kubernetes.io/worker-cnf: ""

Comment 2 or marziano 2020-11-01 15:40:14 UTC
Hi i ran downstream image: v4.7.0-1 of openshift4-cnf-tests.
Client Version: 4.6.0
Kubernetes Version: v1.19.1

No issues.