Bug 1891011

Summary:	Review Request: perl-CPAN-Plugin-Sysdeps - CPAN client plugin for installing system dependencies
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-CPAN-Plugin-Sysdeps-0.66-1.fc34	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-26 13:37:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2020-10-23 14:26:24 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-CPAN-Plugin-Sysdeps/perl-CPAN-Plugin-Sysdeps.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-CPAN-Plugin-Sysdeps/perl-CPAN-Plugin-Sysdeps-0.66-1.fc34.src.rpm
Description:
CPAN::Plugin::Sysdeps is a plugin for CPAN Perl module to install non-CPAN
dependencies automatically. Currently, the list of required system
dependencies is maintained in a static data structure in
CPAN::Plugin::Sysdeps::Mapping.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2020-10-26 11:34:25 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-CPAN-Plugin-Sysdeps-0.66-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 dnf
      1 perl(constant)
      1 perl(CPAN::Distribution)
      1 perl(CPAN::Plugin::Sysdeps)
      1 perl(Data::Dumper) 
      1 perl(Getopt::Long)
      1 perl(IPC::Open3)
      1 perl(List::Util)
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(strict)
      1 perl(Symbol)
      1 perl(warnings)
      1 rpm
      1 /usr/bin/perl
Binary requires are Ok.

$ rpm -qp --provides perl-CPAN-Plugin-Sysdeps-0.66-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(CPAN::Plugin::Sysdeps) = 0.66
      1 perl-CPAN-Plugin-Sysdeps = 0.66-1.fc34
      1 perl(CPAN::Plugin::Sysdeps::Mapping) = 0.66
Binary provides are Ok.

$ rpmlint ./perl-CPAN-Plugin-Sysdeps*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

Comment 2 Petr Pisar 2020-10-26 12:04:56 UTC

https://pagure.io/releng/fedora-scm-requests/issue/30061

Comment 3 Gwyn Ciesla 2020-10-26 13:26:50 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-CPAN-Plugin-Sysdeps

Comment 4 Petr Pisar 2020-10-26 13:37:35 UTC

Thank you for the review and the repository.