Bug 1891011 - Review Request: perl-CPAN-Plugin-Sysdeps - CPAN client plugin for installing system dependencies
Summary: Review Request: perl-CPAN-Plugin-Sysdeps - CPAN client plugin for installing ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-23 14:26 UTC by Petr Pisar
Modified: 2020-10-26 13:37 UTC (History)
2 users (show)

Fixed In Version: perl-CPAN-Plugin-Sysdeps-0.66-1.fc34
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-26 13:37:35 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2020-10-23 14:26:24 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-CPAN-Plugin-Sysdeps/perl-CPAN-Plugin-Sysdeps.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-CPAN-Plugin-Sysdeps/perl-CPAN-Plugin-Sysdeps-0.66-1.fc34.src.rpm
Description:
CPAN::Plugin::Sysdeps is a plugin for CPAN Perl module to install non-CPAN
dependencies automatically. Currently, the list of required system
dependencies is maintained in a static data structure in
CPAN::Plugin::Sysdeps::Mapping.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2020-10-26 11:34:25 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-CPAN-Plugin-Sysdeps-0.66-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 dnf
      1 perl(constant)
      1 perl(CPAN::Distribution)
      1 perl(CPAN::Plugin::Sysdeps)
      1 perl(Data::Dumper) 
      1 perl(Getopt::Long)
      1 perl(IPC::Open3)
      1 perl(List::Util)
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(strict)
      1 perl(Symbol)
      1 perl(warnings)
      1 rpm
      1 /usr/bin/perl
Binary requires are Ok.

$ rpm -qp --provides perl-CPAN-Plugin-Sysdeps-0.66-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(CPAN::Plugin::Sysdeps) = 0.66
      1 perl-CPAN-Plugin-Sysdeps = 0.66-1.fc34
      1 perl(CPAN::Plugin::Sysdeps::Mapping) = 0.66
Binary provides are Ok.

$ rpmlint ./perl-CPAN-Plugin-Sysdeps*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

Comment 3 Gwyn Ciesla 2020-10-26 13:26:50 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-CPAN-Plugin-Sysdeps

Comment 4 Petr Pisar 2020-10-26 13:37:35 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.