Bug 1893332

Created attachment 1725364 [details]
armv7hl build failure with shared fizz trying to link against static folly

Description of problem:
We want to have the stack of Facebook C++ libraries available both as shared and static libraries; because there is no guarantee of ABI stability we bump the shared library soname every release, so any usage from outside Fedora packages probably want to use the static libraries anyway.

When building fizz, we thus need to have both folly-devel and folly-static available. This works reliably on x86_64.

On armv7hl and aarch64, though, when building for F33 and F34 the shared build attempts to link against libfolly.a which fails because libfolly.a was not built with -fPIC:
- F33 https://koji.fedoraproject.org/koji/taskinfo?taskID=54526861
- F34 https://koji.fedoraproject.org/koji/taskinfo?taskID=54525362

(armv7hl static build was already disabled when it failed in a scratch build, so the build passed above because folly-static was not installed. Will upload the scratch log later)

Bizarrely, on F32 aarch64 succeeded ... but ppc64 failed with a different final link error. It succeeded on F33 and F34

- F32 https://koji.fedoraproject.org/koji/taskinfo?taskID=54568825

Version-Release number of selected component (if applicable):
2020.10.26.00-2

How reproducible:
Always

Steps to Reproduce:
1. fedpkg clone fizz
2. cd fizz
3. git checkout 688dad0af01b5bd03f43dcba87d836d09ce53062
4. fedpkg srpm
5. koji build --scratch f34 fizz-2020.10.26.00-2.fc34.src.rpm
6. repeat for F33 and F32

Actual results:
Failed as above

Expected results:
These should succeed

Additional info: