Bug 189384
| Summary: | Review Request: python-ruledispatch: A generic function package for Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ignacio Vazquez-Abrams <ivazqueznet> |
| Component: | Package Review | Assignee: | Orion Poplawski <orion> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | gauret, lmacken |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-07-11 22:52:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779, 189338 | ||
|
Description
Ignacio Vazquez-Abrams
2006-04-19 16:44:10 UTC
- I would suggest http://www.turbogears.org/download/index.html as the URL. At least it gives reference to TurboGears. - md5sum matches 0bdec1022ad28a6819abc99e5f2e5b7c RuleDispatch-0.5a0.dev-r2115.tar.gz 0bdec1022ad28a6819abc99e5f2e5b7c RuleDispatch-0.5a0.dev-r2115.tar.gz.srpm - spec is clean and readable. Question: - What's the latest about packaging/ghosting .pyo files? Bad: - doesn't build on x86_64, needs: %{python_sitearch}/RuleDispatch-%{version}.dev_%{svnrev}-py%{pyver}.egg-info %{python_sitearch}/dispatch instead of sitelib. - rpmlint: W: python-ruledispatch invalid-license PSF or ZPL This matches the PKG-INFO file, though the source file don't say anything. W: python-ruledispatch invalid-url (none) - see above. E: python-ruledispatch zero-length /usr/lib64/python2.4/site-packages/RuleDispatch-0.5a0.dev_r2115-py2.4.egg-info/zip-safe Ignacio seems to be MIA, so I'll help push this one along. http://people.redhat.com/lmacken/python-ruledispatch.spec http://people.redhat.com/lmacken/python-ruledispatch-0.5a0-1.svnr2115.src.rpm * Thu Jul 6 2006 Luke Macken <lmacken> 0.5a0-1.svnr2115 - Use sitearch instead of sitelib in the files - Remove python-abi requirement - Ghost the .pyo files - Add the URL - Release should have gone to 0.svnr2115.1, I think. - Let's get a better %decription than "Something about generic functions in Python." - Is zip-safe necessary? E: python-ruledispatch zero-length /usr/lib64/python2.4/site-packages/RuleDispatch-0.5a0.dev_r2115-py2.4.egg-info/zip-safe > - Release should have gone to 0.svnr2115.1, I think. According to http://fedoraproject.org/wiki/Packaging/NamingGuidelines#PreReleasePackages) (someone please fix this parenthesis) it should be : 0.1.svnr2115 If you want to bump the release without changing the version it will become 0.2.svnr2115 > - Is zip-safe necessary? It looks like a dummy file to avoid the zip extractor bug were empty dirs are not created. Harmless to remove, but harmless to keep also. I would not consider it a blocker (sometimes one just has to ignore rpmlint's warnings) Fixed release and description. http://people.redhat.com/lmacken/python-ruledispatch.spec http://people.redhat.com/lmacken/python-ruledispatch-0.5a0-0.1.svnr2115.src.rpm APPROVED. Luke - are you going to be the maintainer now? I have no problem maintaining this until Ignacio returns.
Imported into CVS, added to owners.list, FC{4,5} branches requested, tagged and
built for fc6.
Thanks!
(please close this bug as NEXTRELEASE; I don't have the privs)
|