Bug 1894149

Summary:	Check for verifying syntax "/etc/foreman-installer/custom-hiera.yaml" file in foreman-maintain upgrade check command failed with misguiding error "Check if checkpoint_segments configuration exists on the system"
Product:	Red Hat Satellite	Reporter:	Naina Jain <naijain>
Component:	Satellite Maintain	Assignee:	Suraj Patil <supatil>
Status:	CLOSED ERRATA	QA Contact:	Jameer Pathan <jpathan>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	6.7.0	CC:	apatel, egolov, gtalreja, kgaikwad, supatil
Target Milestone:	6.9.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	rubygem-foreman_maintain-0.6.14	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1899322 (view as bug list)		Environment:
Last Closed:	2021-04-21 14:48:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Naina Jain 2020-11-03 16:28:51 UTC

Description of problem:
Upgrading from 6.7 with /etc/foreman-installer/custom-hiera.yaml :

~~~~~~~~~~~~~~~~~
s YAML file lets you set your own custom configuration in Hiera for the             <=============================================
# installer puppet modules that might not be exposed to users directly through
# installer arguments.
~~~~~~~~~~~~~~~~~


Version-Release number of selected component (if applicable):
satellite-6.8.0-0.7.beta.el7sat.noarch
satellite-installer-6.8.0.8-1.el7sat.noarch


How reproducible:
100% 


Steps to Reproduce:
1. Have syntax issue in Sat 6.7 with /etc/foreman-installer/custom-hiera.yaml :
~~~~~~~~~~~~~~~
s YAML file lets you set your own custom configuration in Hiera for the             <=============================================
# installer puppet modules that might not be exposed to users directly through
# installer arguments.

~~~~~~~~~~~~~~~

2. Run upgrade to 6.8


Actual results:
2. is supposed to fail with below misguiding error to another Bug

~~~~~~~~~~~~~~~~
Check if checkpoint_segments configuration exists on the system:      [FAIL]
undefined method `key?' for #<String:0x0000000139c960>

~~~~~~~~~~~~~~~~~

Expected results:
1.) Foreman-maintain command should check for syntax issue in /etc/foreman-installer/custom-hiera.yaml should show error related to syntax and not to any other misguiding error


Additional info:

Comment 1 Suraj Patil 2020-11-04 08:10:17 UTC

Created redmine issue https://projects.theforeman.org/issues/31253 from this bug

Comment 2 Bryan Kearney 2020-11-25 12:01:55 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/31253 has been resolved.

Comment 3 Jameer Pathan 2020-12-17 11:17:20 UTC

Verified

Verified with:
- Satelllite 6.9.0 snap 5
- rubygem-foreman_maintain-0.7.0-1.el7sat.noarch

Test steps:
- Have an invalid /etc/foreman-installer/custom-hiera.yaml file
- Run "foreman-maintain health check --label check-postgresql-checkpoint-segments"

Observations:
-  If /etc/foreman-installer/custom-hiera.yaml is not valid yaml then the check gives proper error message.

Running ForemanMaintain::Scenario::FilteredScenario
================================================================================
Check if checkpoint_segments configuration exists on the system:      [FAIL]
Error: File /etc/foreman-installer/custom-hiera.yaml is not a yaml file.
--------------------------------------------------------------------------------
Scenario [ForemanMaintain::Scenario::FilteredScenario] failed.

Comment 6 errata-xmlrpc 2021-04-21 14:48:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Satellite 6.9 Satellite Maintenance Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1312