Bug 1894149 - Check for verifying syntax "/etc/foreman-installer/custom-hiera.yaml" file in foreman-maintain upgrade check command failed with misguiding error "Check if checkpoint_segments configuration exists on the system"
Summary: Check for verifying syntax "/etc/foreman-installer/custom-hiera.yaml" file in...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Satellite Maintain
Version: 6.7.0
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: 6.9.0
Assignee: Suraj Patil
QA Contact: Jameer Pathan
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-11-03 16:28 UTC by Naina Jain
Modified: 2023-12-15 20:00 UTC (History)
5 users (show)

Fixed In Version: rubygem-foreman_maintain-0.6.14
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1899322 (view as bug list)
Environment:
Last Closed: 2021-04-21 14:48:24 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 31253 0 Normal Closed Check for verifying syntax "/etc/foreman-installer/custom-hiera.yaml" file in foreman-maintain upgrade check command fai... 2021-02-05 19:06:33 UTC
Github SatelliteQE testfm pull 266 0 None Merged Add manual tests and test scenario for BZ-1894149 2022-03-07 10:02:40 UTC
Red Hat Knowledge Base (Solution) 5549891 0 None None None 2020-11-12 10:06:15 UTC
Red Hat Product Errata RHBA-2021:1312 0 None None None 2021-04-21 14:48:34 UTC

Description Naina Jain 2020-11-03 16:28:51 UTC
Description of problem:
Upgrading from 6.7 with /etc/foreman-installer/custom-hiera.yaml :

~~~~~~~~~~~~~~~~~
s YAML file lets you set your own custom configuration in Hiera for the             <=============================================
# installer puppet modules that might not be exposed to users directly through
# installer arguments.
~~~~~~~~~~~~~~~~~


Version-Release number of selected component (if applicable):
satellite-6.8.0-0.7.beta.el7sat.noarch
satellite-installer-6.8.0.8-1.el7sat.noarch


How reproducible:
100% 


Steps to Reproduce:
1. Have syntax issue in Sat 6.7 with /etc/foreman-installer/custom-hiera.yaml :
~~~~~~~~~~~~~~~
s YAML file lets you set your own custom configuration in Hiera for the             <=============================================
# installer puppet modules that might not be exposed to users directly through
# installer arguments.

~~~~~~~~~~~~~~~

2. Run upgrade to 6.8


Actual results:
2. is supposed to fail with below misguiding error to another Bug

~~~~~~~~~~~~~~~~
Check if checkpoint_segments configuration exists on the system:      [FAIL]
undefined method `key?' for #<String:0x0000000139c960>

~~~~~~~~~~~~~~~~~

Expected results:
1.) Foreman-maintain command should check for syntax issue in /etc/foreman-installer/custom-hiera.yaml should show error related to syntax and not to any other misguiding error


Additional info:

Comment 1 Suraj Patil 2020-11-04 08:10:17 UTC
Created redmine issue https://projects.theforeman.org/issues/31253 from this bug

Comment 2 Bryan Kearney 2020-11-25 12:01:55 UTC
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/31253 has been resolved.

Comment 3 Jameer Pathan 2020-12-17 11:17:20 UTC
Verified

Verified with:
- Satelllite 6.9.0 snap 5
- rubygem-foreman_maintain-0.7.0-1.el7sat.noarch

Test steps:
- Have an invalid /etc/foreman-installer/custom-hiera.yaml file
- Run "foreman-maintain health check --label check-postgresql-checkpoint-segments"

Observations:
-  If /etc/foreman-installer/custom-hiera.yaml is not valid yaml then the check gives proper error message.

Running ForemanMaintain::Scenario::FilteredScenario
================================================================================
Check if checkpoint_segments configuration exists on the system:      [FAIL]
Error: File /etc/foreman-installer/custom-hiera.yaml is not a yaml file.
--------------------------------------------------------------------------------
Scenario [ForemanMaintain::Scenario::FilteredScenario] failed.

Comment 6 errata-xmlrpc 2021-04-21 14:48:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Satellite 6.9 Satellite Maintenance Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1312


Note You need to log in before you can comment on or make changes to this bug.