Bug 1896497
| Summary: | Review Request: golang-github-google-dap - Go implementation of the Debug Adapter Protocol | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alejandro Sáez Morollón <asm> |
| Component: | Package Review | Assignee: | Olivier Lemasle <o.lemasle> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | o.lemasle, package-review |
| Target Milestone: | --- | Flags: | o.lemasle:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-03-03 18:43:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Alejandro Sáez Morollón
2020-11-10 17:48:51 UTC
It's a dependency for Delve (currently dead) https://src.fedoraproject.org/rpms/delve I've been testing this in COPR: https://copr.fedorainfracloud.org/coprs/alexsaezm/delve/package/golang-github-google-dap/ Delve is retired in Fedora. You want to unretire it? For the spec URL, please prefer the raw spec file (https://pagure.io/golang-github-google-dap/raw/master/f/golang-github-google-dap.spec) which is expected by tools like fedora-review. Please update the package to the latest upstream version: 0.3.0
Otherwise ok, package accepted:
- license ok
- changelog ok
- builds in mock
- spec format ok with guidelines
Rpmlint
-------
Checking: golang-github-google-dap-0.2.0-1.fc34.x86_64.rpm
golang-github-google-dap-devel-0.2.0-1.fc34.noarch.rpm
golang-github-google-dap-debuginfo-0.2.0-1.fc34.x86_64.rpm
golang-github-google-dap-debugsource-0.2.0-1.fc34.x86_64.rpm
golang-github-google-dap-0.2.0-1.fc34.src.rpm
golang-github-google-dap.x86_64: E: shared-lib-without-dependency-information /usr/bin/gentypes
golang-github-google-dap.x86_64: W: no-manual-page-for-binary gentypes
golang-github-google-dap.x86_64: W: no-manual-page-for-binary mockserver
golang-github-google-dap-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/google/go-dap/.goipath
5 packages and 0 specfiles checked; 1 errors, 3 warnings.
Rpmlint (debuginfo)
-------------------
Checking: golang-github-google-dap-debuginfo-0.2.0-1.fc34.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
golang-github-google-dap.x86_64: E: shared-lib-without-dependency-information /usr/bin/gentypes
golang-github-google-dap.x86_64: W: no-manual-page-for-binary gentypes
golang-github-google-dap.x86_64: W: no-manual-page-for-binary mockserver
golang-github-google-dap-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/google/go-dap/.goipath
4 packages and 0 specfiles checked; 1 errors, 3 warnings.
*** Bug 1925286 has been marked as a duplicate of this bug. *** I don't know how this fell through the cracks :( (In reply to Olivier Lemasle from comment #2) > Delve is retired in Fedora. You want to unretire it? Yes, that's my goal. (In reply to Olivier Lemasle from comment #4) > Please update the package to the latest upstream version: 0.3.0 > > Otherwise ok, package accepted: > - license ok > - changelog ok > - builds in mock > - spec format ok with guidelines > > > Rpmlint > ------- > Checking: golang-github-google-dap-0.2.0-1.fc34.x86_64.rpm > golang-github-google-dap-devel-0.2.0-1.fc34.noarch.rpm > golang-github-google-dap-debuginfo-0.2.0-1.fc34.x86_64.rpm > golang-github-google-dap-debugsource-0.2.0-1.fc34.x86_64.rpm > golang-github-google-dap-0.2.0-1.fc34.src.rpm > golang-github-google-dap.x86_64: E: > shared-lib-without-dependency-information /usr/bin/gentypes > golang-github-google-dap.x86_64: W: no-manual-page-for-binary gentypes > golang-github-google-dap.x86_64: W: no-manual-page-for-binary mockserver > golang-github-google-dap-devel.noarch: W: hidden-file-or-dir > /usr/share/gocode/src/github.com/google/go-dap/.goipath > 5 packages and 0 specfiles checked; 1 errors, 3 warnings. > > > Rpmlint (debuginfo) > ------------------- > Checking: golang-github-google-dap-debuginfo-0.2.0-1.fc34.x86_64.rpm > 1 packages and 0 specfiles checked; 0 errors, 0 warnings. > > > Rpmlint (installed packages) > ---------------------------- > golang-github-google-dap.x86_64: E: > shared-lib-without-dependency-information /usr/bin/gentypes > golang-github-google-dap.x86_64: W: no-manual-page-for-binary gentypes > golang-github-google-dap.x86_64: W: no-manual-page-for-binary mockserver > golang-github-google-dap-devel.noarch: W: hidden-file-or-dir > /usr/share/gocode/src/github.com/google/go-dap/.goipath > 4 packages and 0 specfiles checked; 1 errors, 3 warnings. Since your comment, they released another version (0.4.0) so I updated the package to that version: Spec URL: https://pagure.io/golang-github-google-dap/raw/master/f/golang-github-google-dap.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/alexsaezm/delve/fedora-rawhide-x86_64/01958692-golang-github-google-dap/golang-github-google-dap-0.4.0-1.fc35.src.rpm Update is ok, thanks. Package approved. (In reply to Olivier Lemasle from comment #7) > Update is ok, thanks. > Package approved. For some reason I'm getting an error while requesting the repository: Could not execute request_repo: The Bugzilla bug's review was approved over 60 days ago According to this comment[0], it looks like you need to toggle the ACK flag. Would you mind trying that? [0] https://bugzilla.redhat.com/show_bug.cgi?id=1501522#c83 Package approved again ;-) Awesome. Thanks a lot! https://pagure.io/releng/fedora-scm-requests/issue/32144 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-google-dap |