Bug 1896497 - Review Request: golang-github-google-dap - Go implementation of the Debug Adapter Protocol
Summary: Review Request: golang-github-google-dap - Go implementation of the Debug Ad...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Olivier Lemasle
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1925286 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-11-10 17:48 UTC by Alejandro Sáez Morollón
Modified: 2021-03-03 18:43 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-03-03 18:43:57 UTC
Type: ---
Embargoed:
o.lemasle: fedora-review+


Attachments (Terms of Use)

Description Alejandro Sáez Morollón 2020-11-10 17:48:51 UTC
Spec URL: https://pagure.io/golang-github-google-dap/blob/master/f/golang-github-google-dap.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/alexsaezm/delve/fedora-33-x86_64/01645743-golang-github-google-dap/golang-github-google-dap-0.2.0-1.fc33.src.rpm
Description: Go implementation of the Debug Adapter Protocol 
Fedora Account System Username: alexsaezm

Comment 1 Alejandro Sáez Morollón 2020-11-10 17:51:06 UTC
It's a dependency for Delve (currently dead) https://src.fedoraproject.org/rpms/delve

I've been testing this in COPR: https://copr.fedorainfracloud.org/coprs/alexsaezm/delve/package/golang-github-google-dap/

Comment 2 Olivier Lemasle 2020-11-24 14:19:22 UTC
Delve is retired in Fedora. You want to unretire it?

Comment 3 Olivier Lemasle 2020-11-24 14:24:19 UTC
For the spec URL, please prefer the raw spec file (https://pagure.io/golang-github-google-dap/raw/master/f/golang-github-google-dap.spec) which is expected by tools like fedora-review.

Comment 4 Olivier Lemasle 2020-11-24 14:30:58 UTC
Please update the package to the latest upstream version: 0.3.0

Otherwise ok, package accepted:
- license ok
- changelog ok
- builds in mock
- spec format ok with guidelines


Rpmlint
-------
Checking: golang-github-google-dap-0.2.0-1.fc34.x86_64.rpm
          golang-github-google-dap-devel-0.2.0-1.fc34.noarch.rpm
          golang-github-google-dap-debuginfo-0.2.0-1.fc34.x86_64.rpm
          golang-github-google-dap-debugsource-0.2.0-1.fc34.x86_64.rpm
          golang-github-google-dap-0.2.0-1.fc34.src.rpm
golang-github-google-dap.x86_64: E: shared-lib-without-dependency-information /usr/bin/gentypes
golang-github-google-dap.x86_64: W: no-manual-page-for-binary gentypes
golang-github-google-dap.x86_64: W: no-manual-page-for-binary mockserver
golang-github-google-dap-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/google/go-dap/.goipath
5 packages and 0 specfiles checked; 1 errors, 3 warnings.


Rpmlint (debuginfo)
-------------------
Checking: golang-github-google-dap-debuginfo-0.2.0-1.fc34.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


Rpmlint (installed packages)
----------------------------
golang-github-google-dap.x86_64: E: shared-lib-without-dependency-information /usr/bin/gentypes
golang-github-google-dap.x86_64: W: no-manual-page-for-binary gentypes
golang-github-google-dap.x86_64: W: no-manual-page-for-binary mockserver
golang-github-google-dap-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/google/go-dap/.goipath
4 packages and 0 specfiles checked; 1 errors, 3 warnings.

Comment 5 Alejandro Sáez Morollón 2021-02-11 17:38:20 UTC
*** Bug 1925286 has been marked as a duplicate of this bug. ***

Comment 6 Alejandro Sáez Morollón 2021-02-11 18:34:34 UTC
I don't know how this fell through the cracks :(

(In reply to Olivier Lemasle from comment #2)
> Delve is retired in Fedora. You want to unretire it?

Yes, that's my goal.

(In reply to Olivier Lemasle from comment #4)
> Please update the package to the latest upstream version: 0.3.0
> 
> Otherwise ok, package accepted:
> - license ok
> - changelog ok
> - builds in mock
> - spec format ok with guidelines
> 
> 
> Rpmlint
> -------
> Checking: golang-github-google-dap-0.2.0-1.fc34.x86_64.rpm
>           golang-github-google-dap-devel-0.2.0-1.fc34.noarch.rpm
>           golang-github-google-dap-debuginfo-0.2.0-1.fc34.x86_64.rpm
>           golang-github-google-dap-debugsource-0.2.0-1.fc34.x86_64.rpm
>           golang-github-google-dap-0.2.0-1.fc34.src.rpm
> golang-github-google-dap.x86_64: E:
> shared-lib-without-dependency-information /usr/bin/gentypes
> golang-github-google-dap.x86_64: W: no-manual-page-for-binary gentypes
> golang-github-google-dap.x86_64: W: no-manual-page-for-binary mockserver
> golang-github-google-dap-devel.noarch: W: hidden-file-or-dir
> /usr/share/gocode/src/github.com/google/go-dap/.goipath
> 5 packages and 0 specfiles checked; 1 errors, 3 warnings.
> 
> 
> Rpmlint (debuginfo)
> -------------------
> Checking: golang-github-google-dap-debuginfo-0.2.0-1.fc34.x86_64.rpm
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> 
> 
> Rpmlint (installed packages)
> ----------------------------
> golang-github-google-dap.x86_64: E:
> shared-lib-without-dependency-information /usr/bin/gentypes
> golang-github-google-dap.x86_64: W: no-manual-page-for-binary gentypes
> golang-github-google-dap.x86_64: W: no-manual-page-for-binary mockserver
> golang-github-google-dap-devel.noarch: W: hidden-file-or-dir
> /usr/share/gocode/src/github.com/google/go-dap/.goipath
> 4 packages and 0 specfiles checked; 1 errors, 3 warnings.

Since your comment, they released another version (0.4.0) so I updated the package to that version:

Spec URL: https://pagure.io/golang-github-google-dap/raw/master/f/golang-github-google-dap.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/alexsaezm/delve/fedora-rawhide-x86_64/01958692-golang-github-google-dap/golang-github-google-dap-0.4.0-1.fc35.src.rpm

Comment 7 Olivier Lemasle 2021-02-11 22:25:31 UTC
Update is ok, thanks.
Package approved.

Comment 8 Alejandro Sáez Morollón 2021-02-16 14:55:25 UTC
(In reply to Olivier Lemasle from comment #7)
> Update is ok, thanks.
> Package approved.

For some reason I'm getting an error while requesting the repository:

Could not execute request_repo: The Bugzilla bug's review was approved over 60 days ago

According to this comment[0], it looks like you need to toggle the ACK flag. Would you mind trying that?


[0] https://bugzilla.redhat.com/show_bug.cgi?id=1501522#c83

Comment 9 Olivier Lemasle 2021-02-16 15:44:17 UTC
Package approved again ;-)

Comment 10 Alejandro Sáez Morollón 2021-02-16 15:59:37 UTC
Awesome. Thanks a lot!

https://pagure.io/releng/fedora-scm-requests/issue/32144

Comment 11 Mohan Boddu 2021-02-17 14:40:40 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-google-dap


Note You need to log in before you can comment on or make changes to this bug.