Bug 1897273

Summary: [BUG] Insights-clients register fails on OSE RHEL7.9 after updating python2-requests
Product: Red Hat Enterprise Linux 8 Reporter: Sagar Lutade <slutade>
Component: insights-clientAssignee: jcrafts
Status: CLOSED DEFERRED QA Contact: Pavol Kotvan <pakotvan>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 8.3CC: achadha, anowak, aromito, eterrell, fabian, gmccullo, kdixon, klape, lbalhar, link, lphiri, pkhedeka, shivagup
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: 8.3   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-08-04 14:48:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1924613    
Bug Blocks:    

Description Sagar Lutade 2020-11-12 16:54:39 UTC
Description of problem:

Insights client fails after python2-requests package update.

As soon as we have enabled the repo rhel-7-server-ose-3.11-rpms insights-client fails to register or run, because the rhel-7-server-ose-3.11-rpms contains python2-urllib3-1.24.3-1.el7.noarch

[eng] [root@lh982 tmp]# insights-client 
Traceback (most recent call last):
  File "/bin/insights-client", line 5, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 3011, in <module>
    parse_requirements(__requires__), Environment()
  File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 626, in resolve
    raise DistributionNotFound(req)
pkg_resources.DistributionNotFound: urllib3>=1.21.1,<1.24

Comment 2 Jan Zeleny 2020-11-13 08:47:11 UTC
Reassigning to Insights Client (hope I picked the right component), the OpenShift Integration component is for server-side components.

Comment 6 Andreas Nowak 2021-01-22 15:57:31 UTC
atomic package has the same issue with the python2-requests rpm:

atomic-1.22.1-33.gitb507039.el7_8.x86_64

atomic -v --debug
/usr/lib/python2.7/site-packages/requests/__init__.py:91: RequestsDependencyWarning: urllib3 (1.24.3) or chardet (3.0.4) doesn't match a supported version!
  RequestsDependencyWarning)
1.22.1

There are dependencies in the file /usr/lib/python2.7/site-packages/requests/__init__.py

```
...
    # Check urllib3 for compatibility.
    major, minor, patch = urllib3_version  # noqa: F811
    major, minor, patch = int(major), int(minor), int(patch)
    # urllib3 >= 1.21.1, <= 1.23
    assert major == 1
    assert minor >= 21
    assert minor <= 23
...
```

which can't be fulfilled.

python2-requests need to be updated but there is no newer package available and the dependencies in the rpms need to be updated also.

Comment 7 Eduardo Otubo 2021-02-09 12:38:25 UTC
For the record: cloud-init is also having problems with python2-requests enabling the installation of updated urllib and breaking: https://bugzilla.redhat.com/show_bug.cgi?id=1920894

Comment 8 Greg McCullough 2021-02-22 15:53:35 UTC
Hi Fabian, please review comment https://bugzilla.redhat.com/show_bug.cgi?id=1897273#c5 and provide feedback.

Comment 9 Fabian von Feilitzsch 2021-02-22 19:51:37 UTC
The older version of urllib3 does not work with the Kubernetes Python client (it causes hangs), which is why we maintain our own version of it to support ansible-based operators (which make use of the python client). There were also a few CVEs filed that made us increase the version to 1.24.3. I would be in favor of upgrading the requests package, or if we can't do that, fixing the version specification for the requests package we do have. Dropping back to 1.21 of urllib3 will likely cause intermittent hangs for any project making use of the python kubernetes client.

Comment 10 Link Dupont 2021-02-24 15:54:35 UTC
Migrating this bug as part of the effort to close the cloud.redhat.com/Client Product/Component.

Comment 13 Link Dupont 2021-08-04 14:48:23 UTC
The underlying bug that caused this issue has been resolved. This should now be fixed.