Bug 1898132
| Summary: | Review Request: perl-Net-Ping - Check a remote host for reachability | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Pisar <ppisar> |
| Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jplesnik, package-review |
| Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Net-Ping-2.74-1.fc34 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-11-19 17:59:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Petr Pisar
2020-11-16 13:40:30 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
Tests failed
FIX: Network tests failed with same errors in mock and in koji.
More details: https://koji.fedoraproject.org/koji/taskinfo?taskID=55688312
BuildRequires are ok
I can check binary requires and provides without successful build.
FIX: Please fix the tests
$ rpmlint ./perl-Net-Ping*
perl-Net-Ping.src: W: spelling-error Summary(en_US) reachability -> reach ability, reach-ability, readability
perl-Net-Ping.src: W: spelling-error %description -l en_US reachability -> reach ability, reach-ability, readability
1 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok
Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items and provide a new spec file.
Resolution:
NOT approved
Thanks for testing it in Koji. I patched the network tests rather than disabling all of them with PERL_CORE=1. An updated package is on the same address. > Tests failed > FIX: Network tests failed with same errors in mock and in koji. > More details: > https://koji.fedoraproject.org/koji/taskinfo?taskID=55688312 Tests passed now. > I can't check binary requires and provides without successful build. > FIX: Please fix the tests Solved $ rpm -qp --requires perl-Net-Ping-2.74-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(constant) 1 perl(Exporter) 1 perl(Fcntl) 1 perl(FileHandle) 1 perl(IO::Socket::INET) 1 perl(:MODULE_COMPAT_5.32.0) 1 perl(POSIX) 1 perl(Socket) >= 2.007 1 perl(strict) 1 perl(Time::HiRes) 1 perl(vars) 1 perl(:VERSION) >= 5.2.0 Binary requires are Ok. $ rpm -qp --provides perl-Net-Ping-2.74-1.fc34.noarch.rpm | sort | uniq -c 1 perl(Net::Ping) = 2.74 1 perl-Net-Ping = 2.74-1.fc34 Binary provides are Ok. The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Net-Ping Thank you for the review and the repository. I will close this report after disabling the subpackage perl.spec. Removed from perl-5.32.0-467.fc34. |