Spec URL: https://ppisar.fedorapeople.org/perl-Net-Ping/perl-Net-Ping.spec SRPM URL: https://ppisar.fedorapeople.org/perl-Net-Ping/perl-Net-Ping-2.74-1.fc34.src.rpm Description: Net::Ping module contains methods to test the reachability of remote hosts on a network. Fedora Account System Username: ppisar This is a dual-lived package and it will be removed from perl.spec after adding this one.
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok Tests failed FIX: Network tests failed with same errors in mock and in koji. More details: https://koji.fedoraproject.org/koji/taskinfo?taskID=55688312 BuildRequires are ok I can check binary requires and provides without successful build. FIX: Please fix the tests $ rpmlint ./perl-Net-Ping* perl-Net-Ping.src: W: spelling-error Summary(en_US) reachability -> reach ability, reach-ability, readability perl-Net-Ping.src: W: spelling-error %description -l en_US reachability -> reach ability, reach-ability, readability 1 packages and 1 specfiles checked; 0 errors, 2 warnings. Rpmlint is ok Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items and provide a new spec file. Resolution: NOT approved
Thanks for testing it in Koji. I patched the network tests rather than disabling all of them with PERL_CORE=1. An updated package is on the same address.
> Tests failed > FIX: Network tests failed with same errors in mock and in koji. > More details: > https://koji.fedoraproject.org/koji/taskinfo?taskID=55688312 Tests passed now. > I can't check binary requires and provides without successful build. > FIX: Please fix the tests Solved $ rpm -qp --requires perl-Net-Ping-2.74-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(constant) 1 perl(Exporter) 1 perl(Fcntl) 1 perl(FileHandle) 1 perl(IO::Socket::INET) 1 perl(:MODULE_COMPAT_5.32.0) 1 perl(POSIX) 1 perl(Socket) >= 2.007 1 perl(strict) 1 perl(Time::HiRes) 1 perl(vars) 1 perl(:VERSION) >= 5.2.0 Binary requires are Ok. $ rpm -qp --provides perl-Net-Ping-2.74-1.fc34.noarch.rpm | sort | uniq -c 1 perl(Net::Ping) = 2.74 1 perl-Net-Ping = 2.74-1.fc34 Binary provides are Ok. The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved
https://pagure.io/releng/fedora-scm-requests/issue/30795
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Net-Ping
Thank you for the review and the repository. I will close this report after disabling the subpackage perl.spec.
Removed from perl-5.32.0-467.fc34.