Bug 1898828

> (A) What exactly are the LocalVolumeDiscovery and LocalVolumeSet CRs used for, compared to the resources in the previous releases?

 LocalVolumeDiscovery is for automated reporting of device details and status, and is used to populate the device management UI under 
Compute>Nodes>NodeXXX>Disks (replace disk from UI uses this page )
LocalVolumeSet is for automated provisioning of devices into PVs according to some criteria


> (B) Your instructions are based in the command line, but it looks like OCP has the ability to create a LocalVolumeSet using the web console, which is the preferred method for OCS.
> I can document both, but can you confirm the steps for the web console?

Documenting both would be great if the timeframe allows, the UI would be preferred, but the LSO UI doesn't work if the LSO is not installed in openshift-local-storage (default in 4.5 and lower): https://bugzilla.redhat.com/show_bug.cgi?id=1895263


> I think steps for both are provided here [1] but if you could review that would be great. 🙂
[1] https://docs.openshift.com/container-platform/4.6/storage/persistent_storage/persistent-storage-local.html#local-storage-discovery_persistent-storage-local

> Specifically:

> LocalVolumeDiscovery creation (?)

> 1. Log in to OpenShift web console as an administrator.
> 2. Click Operators → Installed Operators and click on the Local Volume Discovery tab.
> 3. Click Create Local Volume Discovery.
>   a. Select either All nodes or Select nodes, depending on whether you want to discover available disks on all or specific nodes.
>      Only worker nodes are available, regardless of whether you filter using All nodes or Select nodes.
>   b. Click Create.

> A local volume discovery instance named auto-discover-devices is displayed.

> LocalVolumeSet creation (?)


> 1. Log in to OpenShift web console as an administrator.
> 2. Click Operators → Installed Operators and select Local Storage from the list of Operators.
> 3. Select Local Volume Set → Create Local Volume Set.
>    a. Enter a volume set name and a storage class name.
>       Choose All nodes or Select nodes to apply filters accordingly.
>       Only worker nodes are available, regardless of whether you filter using All nodes or Select nodes.
>    b. Select the disk type, mode, size, and limit you want to apply to the local volume set, and click Create.
> 
>     A message displays after several minutes, indicating that the "Operator reconciled successfully."
> 

These UI steps look good. Still won't work unless LSO is in openshift-local-storage until the bugfix makes it into an OCP z release.

Looks really good overall! Some changes required based on recent discussions.

A)

> apiVersion: local.storage.openshift.io/v1alpha1
> kind: LocalVolumeDiscovery
> metadata:
>   name: auto-discover-devices
> spec:
>   nodeSelector:
>     nodeSelectorTerms:
>       - matchExpressions:
>           - key: cluster.ocs.openshift.io/openshift-storage
>             operator: Exists

Had some discussion today, and it turns out we need to amend the selector like this:

apiVersion: local.storage.openshift.io/v1alpha1
kind: LocalVolumeDiscovery
metadata:
  name: auto-discover-devices
spec:
  nodeSelector:
    nodeSelectorTerms:
      - matchExpressions:
          - key: kubernetes.io/hostname
            operator: In
            values:
            - worker1
            - worker2
            - worker3

B)
i) the indentation didn't render properly:

> models: # list of models to allow
>       - SAMSUNG - Crucial_CT525MX3


ii) Similarly to A), for LocalVolumeSet, we need to change the selector format:

> 5.1.1.2. Creating a LocalVolumeSet custom resource using the command line

apiVersion: local.storage.openshift.io/v1alpha1
kind: LocalVolumeSet
metadata:
  name: localblock
spec:
  nodeSelector:
    nodeSelectorTerms:
      - matchExpressions:
          - key: kubernetes.io/hostname
            operator: In
            values:
            - worker1
            - worker2
            - worker3

iii)

please change the default minSize to 50G, and add a note at the bottom saying: "select a reasonable minSize to avoid to possibility of system partitions being included"

> minSize: 10G

iv)


Please add "optional" to the comment next to the "models" and "vendors" fields

C) 

> Persistent volumes

nitpick: I think this should be PeristentVolumes to indicate that they are a type.

D)

> Verification steps

please replace "minikube" with "ip-10-0-147-124.us-east-2.compute.internal" to make it seem like these examples came from an OpenShift node

> Events:
>   Type    Reason      Age          From                Message
>   ----    ------      ----         ----                -------
>   Normal  Discovered  2m30s (x4    localvolumeset-     minikube - found possible
>           NewDevice   over 2m30s)  symlink-controller  matching disk, waiting
>                                                        1m0s to claim
>   Normal  FoundMatch  89s (x4      localvolumeset-     minikube - symlinking
>           ingDisk     over 89s)    symlink-controller  matching disk
>

> please change the default minSize to 50G, and add a note at the bottom saying: "select a reasonable minSize to avoid to possibility of system partitions being included"

this is to WA https://bugzilla.redhat.com/show_bug.cgi?id=1897050
no fix is planned for this bug, just similar OCP documentation

Also, are the references to this guide from the Replace and Scale guides going to be in a different bug?